Terminal Shell Integration Write data-based tests

[bpasero]

1) VSCode Smoke Tests (Electron)
       Terminal
         Terminal Shell Integration
           Write data-based tests
             "before each" hook for "should handle the simple case":
     Error: Timeout: get terminal buffer '#terminal .terminal-wrapper' after 20 seconds.
      at Code.poll (D:\a\_work\1\s\test\automation\out\code.js:233:23)
      at async Code.waitForTerminalBuffer (D:\a\_work\1\s\test\automation\out\code.js:204:9)
      at async Terminal.waitForTerminalText (D:\a\_work\1\s\test\automation\out\terminal.js:272:13)
      at async Terminal.createEmptyTerminal (D:\a\_work\1\s\test\automation\out\terminal.js:149:9)
      at async Context.<anonymous> (out\areas\terminal\terminal-shellIntegration.test.js:96:17)

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=347238&view=logs&j=1513fbef-2318-507e-ee36-12b21e276dbb&t=def65761-9a16-5716-256a-108b1ba4b97d&l=170

[ulugbekna]

@Tyriar @meganrogge

Let's either disable or fix this test. This test's failing very frequently - here failed again https://dev.azure.com/monacotools/Monaco/_build/results?buildId=347664&view=logs&j=0d7e0e2e-c0e1-55c1-dc70-78a17521fc10&t=b87c4fc3-66cd-59a4-5cd7-aab9b2e1d71b&l=152

[Tyriar]

This is failing before the test actually runs when it's just trying to create a simple terminal:

vscode/test/smoke/src/areas/terminal/terminal-shellIntegration.test.ts

Lines 97 to 99 in 4318ad2

	beforeEach(async function () {
	// Use the simplest profile to get as little process interaction as possible
	await terminal.createEmptyTerminal();

vscode/test/automation/src/terminal.ts

Lines 161 to 176 in 4318ad2

	async createEmptyTerminal(expectedLocation?: 'editor' | 'panel'): Promise<void> {
	await this.createTerminal(expectedLocation);
	// Run a command to ensure the shell has started, this is used to ensure the shell's data
	// does not leak into the "empty terminal"
	await this.runCommandInTerminal('echo "initialized"');
	await this.waitForTerminalText(buffer => buffer.some(line => line.startsWith('initialized')));
	// Erase all content and reset cursor to top
	await this.runCommandWithValue(TerminalCommandIdWithValue.WriteDataToTerminal, `${csi('2J')}${csi('H')}`);
	// Force windows pty mode off; assume all sequences are rendered in correct position
	if (process.platform === 'win32') {
	await this.runCommandWithValue(TerminalCommandIdWithValue.WriteDataToTerminal, `${vsc('P;IsWindows=False')}`);
	}
	}

Unfortunately it's a little difficult to investigate the flake since we don't seem to get playwright traces for web or remote.

[Tyriar]

Part of these failures are beforeEach doesn't respect the outer retries here:

vscode/test/smoke/src/areas/terminal/terminal.test.ts

Lines 20 to 21 in 4318ad2

	// Retry tests 3 times to minimize build failures due to any flakiness
	this.retries(3);

Ideally we wouldn't have any flakiness, but it's hard when there are external processes involved, evolving CI machines, etc. Having a flaky test retry is better than no test.