Skip to content

Add shell type to shell integration details in terminal tab hover #253266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jul 1, 2025

This change adds the shell type information to the shell integration details shown in terminal tab hover tooltips when detailed view is enabled.

Before

When hovering over a terminal tab with shell integration enabled, the detailed tooltip showed:

Shell integration: Rich

- Seen sequences: `A`, `B`, `C`
- Prompt type: `PS1`
- Prompt input: `ls -la`

After

Now the shell type is included at the beginning of the detailed additions:

Shell integration: Rich

- Shell type: `bash`
- Seen sequences: `A`, `B`, `C`
- Prompt type: `PS1`
- Prompt input: `ls -la`

Implementation

  • Added a conditional check for instance.shellType in the refreshShellIntegrationInfoStatus function
  • Uses the same formatting pattern as other detailed additions: Shell type: \${shellType}``
  • Positioned at the beginning of the detailed additions list for logical grouping
  • Gracefully handles cases where shell type is undefined

The shell type will display values like bash, zsh, pwsh, fish, cmd, etc., providing users with clear visibility into what shell is being used in each terminal.

Fixes #253052.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • electronjs.org
    • Triggering command: node-gyp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@Copilot Copilot AI assigned Copilot and Tyriar Jul 1, 2025
@Tyriar Tyriar added this to the July 2025 milestone Jul 1, 2025
Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Add shell type to shell integration details in terminal tab hover Add shell type to shell integration details in terminal tab hover Jul 1, 2025
@Copilot Copilot AI requested a review from Tyriar July 1, 2025 12:26
Copilot finished work on behalf of Tyriar July 1, 2025 12:26
@Tyriar Tyriar marked this pull request as ready for review July 7, 2025 11:40
@Tyriar Tyriar enabled auto-merge July 7, 2025 11:40
@Tyriar Tyriar merged commit d1ec617 into main Jul 7, 2025
19 checks passed
@Tyriar Tyriar deleted the copilot/fix-253052 branch July 7, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shell type to shell integration details in terminal tab hover
3 participants