-
-
Notifications
You must be signed in to change notification settings - Fork 202
[TableOfContents] Add a label option #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The failing check
So I don't think that is something that I can fix |
Which produces invalid HTML: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/ul#technical_summary |
Have you considered using the ## Table of Contents
[TOC] |
I wanted the heading to be more clearly part of the TOC itself, so that is why I didn't have a placeholder.
Good point - what would you think of having a wrapping div when a label is requested? <div class="table-of-contents-wrapper">
<strong>Table of Contents</strong>
<ul class="table-of-contents">
<li>...
</ul>
</div> |
By default no label is shown, but if one is set it is added as a `<strong>` before the first item in the table of contents.
b7599cb
to
9cb5d18
Compare
@colinodell I've fixed this so that the HTML is valid, but now this is a tiny BC break because of the new TableOfContentsWrapper class that I introduced. Is this BC break acceptable in a minor version? If not, I can turn |
By default no label is shown, but if one is set it is added as a
<strong>
before the first item in the table of contents.