Pin third party actions #3981
Merged
Pin third party actions #3981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-jokic
requested review from
mumoshu,
toast-gear,
rentziass and
a team
as code owners
Link-
reviewed
Mar 24, 2025
| value: ${{steps.config-token.outputs.token}} | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| uses: docker/setup-buildx-action@b5ca514318bd6ebac0fb2aedd5d36ec1b5c232a2 |
There was a problem hiding this comment.
Thinking out loud, it's going to be nightmare upgrading these later if we don't know to which version they point to exactly.
How do you feel about adding a comment above each one to reference the version that the SHA points to?
Link-
reviewed
Mar 24, 2025
Link-
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String Formatting:
.github/actions/setup-arc-e2e/action.yaml, [1];.github/workflows/arc-publish-chart.yaml, [2];.github/workflows/arc-validate-chart.yaml, [3];.github/workflows/arc-validate-runners.yaml, [4];.github/workflows/gha-publish-chart.yaml, [5];.github/workflows/gha-validate-chart.yaml, [6];.github/workflows/global-publish-canary.yaml, [7];.github/workflows/go.yaml, [8]Action Version Updates:
.github/actions/setup-arc-e2e/action.yaml, [1] [2];.github/workflows/arc-publish-chart.yaml, [3] [4] [5];.github/workflows/arc-validate-chart.yaml, [6] [7];.github/workflows/gha-publish-chart.yaml, [8] [9];.github/workflows/gha-validate-chart.yaml, [10] [11] [12];.github/workflows/global-publish-canary.yaml, [13] [14]These changes improve the consistency and reliability of the CI/CD workflows by ensuring uniform string formatting and pinning action versions to specific commits.