Skip to content

[Update Request]: OpenJS.Electron split major versions into separate package indentifiers #247812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dvd-Znf opened this issue Apr 12, 2025 · 4 comments · May be fixed by #250765
Closed

[Update Request]: OpenJS.Electron split major versions into separate package indentifiers #247812

Dvd-Znf opened this issue Apr 12, 2025 · 4 comments · May be fixed by #250765
Labels
Package-Update This package needs to be updated

Comments

@Dvd-Znf
Copy link
Contributor

Dvd-Znf commented Apr 12, 2025

What type of update are you requesting?

A change to the Package Identifier

Current Package Identifier

OpenJS.Electron

Package Version

all versions

Please describe the changes you would like to see

OpenJS.Electron versions should be split into separate package identifiers (OpenJS.Electron.33 OpenJS.Electron.34 and OpenJS.Electron.35 respectively) in order to provide newer releases for all supported major versions

See https://www.electronjs.org/docs/latest/tutorial/electron-timelines
&& https://www.electronjs.org/docs/latest/tutorial/electron-versioning

@Dvd-Znf Dvd-Znf added Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated labels Apr 12, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Apr 12, 2025
@KarbitsCode
Copy link
Contributor

How about the monikers though, should we remove them? Or replace it to be like electron-34, electron-35, etc?

@Dvd-Znf
Copy link
Contributor Author

Dvd-Znf commented Apr 13, 2025

How about the monikers though, should we remove them? Or replace it to be like electron-34, electron-35, etc?

Replacing the monikers as you suggested would indeed be nice

Edit:
Keeping the same monikers is also an option since winget will just show all the available versions
So, in anycase, there is no need to remove them

@KarbitsCode
Copy link
Contributor

That should be all done!

@Dvd-Znf
Copy link
Contributor Author

Dvd-Znf commented Apr 24, 2025

Closing: solved

Tysm @KarbitsCode !! <3

@Dvd-Znf Dvd-Znf closed this as completed Apr 24, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Triage This work item needs to be triaged by a member of the core team. Help-Wanted This is a good candidate work item from the community. labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package-Update This package needs to be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants