Skip to content

New version: DuckStudio.GitHubView version 1.0.4 #247929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2025
Merged

New version: DuckStudio.GitHubView version 1.0.4 #247929

merged 2 commits into from
Apr 23, 2025
+154 −0

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Apr 13, 2025 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.10 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Sorry, something went wrong.

@Dragon1573
New version: DuckStudio.GitHubView version 1.0.4
Loading
Loading status checks…
247af5f 
Signed-off-by: Dragon1573 <49941141+Dragon1573@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-57-247929-20250413-1

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 13, 2025
@stephengillie
Copy link
Collaborator

Hi @DuckDuckStudio,

Do you approve of these changes?

(Automated response - build 1042.)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Review This work item needs to be reviewed by a member of another team. label Apr 13, 2025
DuckDuckStudio

This comment was marked as outdated.

Sign in to view

DuckDuckStudio
DuckDuckStudio reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@DuckDuckStudio DuckDuckStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dragon1573 我在此版本将依赖从 .NET 8 改为了 .NET 9 。
（很抱歉这么晚才在动车上发现这个问题🙏）

@Dragon1573 @DuckDuckStudio
Apply suggestions from code review
Loading
Loading status checks…
1d48874 
- Bump dependencies to .NET 9 instead of .NET 8

Co-authored-by: 鸭鸭「カモ」 <89643991+DuckDuckStudio@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-57-247929-20250415-1

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed New-Manifest labels Apr 15, 2025
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Apr 15, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 15, 2025
@Dragon1573
Copy link
Contributor Author

image

Further investigation required. 🙏🏼

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Apr 15, 2025
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335187 2025-04-15 05:52:33.777 [FAIL] Installer failed security check. Url: https://github.com/DuckDuckStudio/GitHubView/releases/download/1.0.4/GitHubView-1.0.4-windows-latest.zip Result: 0x80004005 MSI (s) (00:60) [05:52:26:090]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'. MSI (s) (00:60) [05:52:26:090]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'. MSI (s) (00:60) [05:52:26:090]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'. MSI (s) (00:60) [05:52:26:090]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'. MSI (s) (00:60) [05:52:26:090]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'. MSI (s) (00:60) [05:52:27:247]: Executing op: ComponentRegister(ComponentId={10ABCE6F-DF6C-5184-8048-607130BB0DCB},KeyPath=2285\SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules\C:\Program Files\dotnet\shared\Microsoft.NETCore.App\9.0.4\mscordaccore.dll,State=3,,Disk=1,SharedDllRefCount=0,BinaryType=1) MSI (s) (00:60) [05:52:28:668]: Executing op: RegOpenKey(Root=-2147483646,Key=SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules,,BinaryType=1,,) Property(S): ErrorDialog = ErrorDlg Property(S): OutOfDiskSpace = 0 Property(S): OutOfNoRbDiskSpace = 0 Property(S): PrimaryVolumeSpaceAvailable = 0 Property(S): PrimaryVolumeSpaceRequired = 0 Property(S): PrimaryVolumeSpaceRemaining = 0 MSI (s) (00:2C) [05:52:29:184]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'. MSI (s) (00:2C) [05:52:29:184]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'. MSI (s) (00:2C) [05:52:29:184]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'. MSI (s) (00:2C) [05:52:29:184]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'. MSI (s) (00:2C) [05:52:29:184]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'. MSI (s) (00:B0) [05:52:29:825]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'. MSI (s) (00:B0) [05:52:29:825]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'. MSI (s) (00:B0) [05:52:29:825]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'. MSI (s) (00:B0) [05:52:29:825]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'. MSI (s) (00:B0) [05:52:29:825]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'. 2025-04-15 06:00:04.731 [FAIL] Installer failed security check. Url: https://github.com/DuckDuckStudio/GitHubView/releases/download/1.0.4/GitHubView-1.0.4-windows-latest.zip Result: 0x80004005 MSI (s) (44:8C) [05:59:54:455]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'. MSI (s) (44:8C) [05:59:54:455]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'. MSI (s) (44:8C) [05:59:54:455]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'. MSI (s) (44:8C) [05:59:54:455]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'. MSI (s) (44:8C) [05:59:54:455]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'. MSI (s) (44:8C) [05:59:55:390]: Executing op: ComponentRegister(ComponentId={03ED823B-C952-5536-BACB-A61F831383C8},KeyPath=0285\SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules\C:\Program Files\dotnet\shared\Microsoft.NETCore.App\9.0.4\mscordaccore.dll,State=3,,Disk=1,SharedDllRefCount=0,BinaryType=0) MSI (s) (44:8C) [05:59:56:594]: Executing op: RegOpenKey(Root=-2147483646,Key=SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules,,BinaryType=0,,) MSI (s) (44:88) [05:59:56:964]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'. MSI (s) (44:88) [05:59:56:964]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'. MSI (s) (44:88) [05:59:56:964]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'. MSI (s) (44:88) [05:59:56:964]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'. MSI (s) (44:88) [05:59:56:964]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'. MSI (s) (44:00) [05:59:57:397]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'. MSI (s) (44:00) [05:59:57:397]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'. MSI (s) (44:00) [05:59:57:397]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'. MSI (s) (44:00) [05:59:57:397]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'. MSI (s) (44:00) [05:59:57:397]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'. | Hex | Dec | Inverted Dec | Symbol | Description | | --- | --- | --- | --- | --- | | 00000000 | 0 | -4294967296 | ERROR_SUCCESS | The operation completed successfully. | | 80004005 | -2147467259 | 2147500037 | E_Fail | Resource missing | | 8A15002D | -1978335187 | 2316632109 | APPINSTALLER_CLI_ERROR_INSTALLER_SECURITY_CHECK_FAILED | Installer failed security check. Another script should retry this about every 18 hours. | | 8A15005E | -1978335138 | 2316632158 | APPINSTALLER_CLI_ERROR_PINNED_CERTIFICATE_MISMATCH | The server certificate did not match any of the expected values. |

Hex Dec Inverted Dec Symbol Description
00000000 0 -4294967296 ERROR_SUCCESS The operation completed successfully.
00000000 0 -4294967296 ERROR_SUCCESS The operation completed successfully.
00000000 0 -4294967296 ERROR_SUCCESS The operation completed successfully.
00000012 18 -4294967278 ERROR_NO_MORE_FILES There are no more files.
80004005 -2147467259 2147500037 E_Fail Resource missing
80004005 -2147467259 2147500037 E_Fail Resource missing
80004005 -2147467259 2147500037 E_Fail Resource missing
8A15002D -1978335187 2316632109 APPINSTALLER_CLI_ERROR_INSTALLER_SECURITY_CHECK_FAILED Installer failed security check. Another script should retry this about every 18 hours.
8A15002D -1978335187 2316632109 APPINSTALLER_CLI_ERROR_INSTALLER_SECURITY_CHECK_FAILED Installer failed security check. Another script should retry this about every 18 hours.
8A15002D -1978335187 2316632109 APPINSTALLER_CLI_ERROR_INSTALLER_SECURITY_CHECK_FAILED Installer failed security check. Another script should retry this about every 18 hours.
8A15005E -1978335138 2316632158 APPINSTALLER_CLI_ERROR_PINNED_CERTIFICATE_MISMATCH The server certificate did not match any of the expected values.
8A15005E -1978335138 2316632158 APPINSTALLER_CLI_ERROR_PINNED_CERTIFICATE_MISMATCH The server certificate did not match any of the expected values.
8A15005E -1978335138 2316632158 APPINSTALLER_CLI_ERROR_PINNED_CERTIFICATE_MISMATCH The server certificate did not match any of the expected values.

(Automated response - build 1042.)

@DuckDuckStudio
Copy link
Contributor

DuckDuckStudio commented Apr 15, 2025 •
edited
Loading

Installation failed with exit code -1978335187 2025-04-15 05:52:33.777 [FAIL] Installer failed security check. Url: https://github.com/DuckDuckStudio/GitHubView/releases/download/1.0.4/GitHubView-1.0.4-windows-latest.zip Result: 0x80004005

guessed it... This could mean that this PR needs multiple attempts in validation pipeline...

zip
屏幕截图 2025-04-16 065729

image
(cut out)

portable
屏幕截图 2025-04-16 064426

I think we can try re-running the validation pipeline now :)

@ItzLevvie
Copy link
Contributor

@wingetbot run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Installation-Error Error installing application labels Apr 16, 2025
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-57-247929-20250416-1

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Apr 23, 2025
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Apr 23, 2025
@Dragon1573
Copy link
Contributor Author

Important

CC @stephengillie 🙏🏼

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Apr 23, 2025
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Apr 23, 2025
@ItzLevvie
Copy link
Contributor

[Policy] Needs-Manual-Merge

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Manual-Merge The pull request requires a manual merge from a repository maintainer Needs-Attention This work item needs to be reviewed by a member of the core team. labels Apr 23, 2025
@ItzLevvie
Copy link
Contributor

[Policy] Reset Feedback
[Policy] Reset Labels

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Review This work item needs to be reviewed by a member of another team. labels Apr 23, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 23, 2025
@stephengillie stephengillie merged commit c7144f2 into microsoft:master Apr 23, 2025
1 check passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Dragon1573 Dragon1573 deleted the issues/247919 branch April 24, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie

@microsoft-github-policy-service microsoft-github-policy-service[bot]

@DuckDuckStudio DuckDuckStudio

@stephengillie stephengillie

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Manual-Merge The pull request requires a manual merge from a repository maintainer New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: DuckStudio.GitHubView version 1.0.4
5 participants
@Dragon1573 @wingetbot @stephengillie @DuckDuckStudio @ItzLevvie