Skip to content

Add requires statement to SandboxTest.ps1 #247863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add requires statement to SandboxTest.ps1 #247863

wants to merge 1 commit into from

Conversation

jedieaston
Copy link
Contributor

@jedieaston jedieaston commented Apr 13, 2025 •
edited by microsoft-github-policy-service bot
Loading

It doesn't run under Windows PowerShell and I got confused :(

Checklist for Pull Requests

  • Have you signed the Contributor License Agreement?
  • Is there a linked Issue?
    Note: <path> is the directory's name containing the manifest you're submitting.
Microsoft Reviewers: Open in CodeFlow

@jedieaston
Add requires statement to SandboxTest.ps1
47db3a2 
It doesn't run under Windows PowerShell and I got confused :(
@jedieaston jedieaston requested review from denelon and a team as code owners April 13, 2025 01:33
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Apr 13, 2025
@ItzLevvie
Copy link
Contributor

I haven't used SandboxTest in 4 years so I will cc @Trenly @mdanish-kh

Trenly
Trenly approved these changes Apr 13, 2025
View reviewed changes
Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be better for me to figure out why this isn’t working in Windows Powershell, but I can do that as a separate PR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 13, 2025
@ItzLevvie
Copy link
Contributor

[Policy] Needs-Manual-Merge

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Manual-Merge The pull request requires a manual merge from a repository maintainer label Apr 13, 2025
@mdanish-kh mdanish-kh mentioned this pull request Apr 13, 2025
Merged
@jedieaston
Copy link
Contributor Author

Superseded by #247924

@jedieaston jedieaston closed this Apr 14, 2025
@jedieaston jedieaston deleted the shes-pretty-modern branch April 14, 2025 21:06
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trenly Trenly

@denelon denelon

Assignees

@stephengillie stephengillie

Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Manual-Merge The pull request requires a manual merge from a repository maintainer Project-File
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jedieaston @wingetbot @ItzLevvie @Trenly @stephengillie