-
Notifications
You must be signed in to change notification settings - Fork 219
feat: add support for 20240701 MongoCluster #4773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Once you've removed a few things that shouldn't be needed in the PR, we'll trigger CI. You can run the same checks locally by running task ci
if you want to check for errors in advance.
v2/internal/controllers/documentdb_mongocluster_crud_v1api20240701_test.go
Show resolved
Hide resolved
The CI test run failed with this error:
What does this mean? There's no recording of the new sample, so it's trying to run live against Azure, which doesn't work. The fix is easy - commit a recording that shows the sample works. (See Create a sample for more information). |
@theunrepentantgeek Thanks! I've just added a new recording |
There's something failing in CI that I need to investigate further, I'll report back once I've worked out what's going on. |
The issue with CI seems to be that the replay test is having trouble finishing in time because it took a long time for the mongo DB to be created when recording, so there are a lot of requests/responses to Azure to play through to simulate, which is taking longer than the 2m timeout. It should be able to go through them pretty quickly though due to how we have requeues configured... I'll look into it further. |
Can you either re-record the recording for the sample test (the other recording is fine), or manually go edit the sample recording file and remove some of the >300 calls to I'll also see if I can't fix what's causing us to take longer than we should trying to get through 300 requests, we should be able to do it in 120s in replay mode. |
Ah thanks! I manually cut down most of those repeated polling calls, so now there's just a handful (<10). The whole recording is now 27 requests. |
/ok-to-test sha=94a85f1 |
I think you removed too much from the recording?
|
What this PR does
This adds support for CosmosDB Vcore (MongoCluster) and its associated firewall rules. I chose to use the latest stable API version available (2024-07-01)
How does this PR make you feel?
Checklist