Skip to content

Fix poll error in process.libs() and clean up maps parsing #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from

Conversation

R42ccoon
Copy link

@R42ccoon R42ccoon commented Apr 17, 2025

  • Fix poll() error : deleting the not because the function returns None if the process is running
  • Clean up maps parsing : replace memory_maps() by maps() and remove useless code

@R42ccoon
Copy link
Author

R42ccoon commented Jul 8, 2025

Any update ?

@peace-maker
Copy link
Member

Yes, sorry, I always wanted to check if this was broken before adding the poll() call at the beginning, since you removed parsing of the .addr attribute, but always forgot when being back at a computer. It seems like we need better tests for this function regardless :D

Can you confirm this was broken and the addr parsing isn't needed anymore?

@R42ccoon
Copy link
Author

The addr parsing is already done by maps(). Also, i edited the commit to move the poll() check from libs() to maps(), because maps() is called is others functions. And i have added error handling, i put RuntimeError but there may be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants