-
Notifications
You must be signed in to change notification settings - Fork 139
Implement Eq
derive (#163)
#479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ping @JelteF |
ping @JelteF |
JelteF
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #163
Synopsis
As our
PartialEq
derive infers trait bounds correctly for generic cases, we need also anEq
derive for doing the same.Solution
derive(Eq)
instd
usescore::cmp::AssertParamIsEq
to assert that fields' types are indeedEq
in itsEq::assert_receiver_is_total_eq()
method. However, they both are#[doc(hidden)]
and not a stable part ofstd
, so we cannot reuse them blindly.However, instead, we could just put the appropriate trait bounds in the
where
clause of the generatedEq
impl
:The only situation where this fails is when the field type uses the self-type recursively:
In this case, we cannot generate
Option<Box<Foo>>: Eq
trait bound, because will hit the compilation error:For such fields, we need to do the similar static assertion as
std
does, that's why introduce our ownderive_more::__private::AssertParamIsEq
helper type. In contrast withstd
, we do generate these assertions (if needed) in an inherent method, rather than introducing a trait for it.Checklist