Fix __FUNCSIG__ parsing on x86 by explicitly declaring the calling convention #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes parsing of enum value names on MSVC x86, by explicitly specifying the calling convention as __cdecl. Calling conventions aren't really a thing on x64, but on x86 the default calling convention can be changed w/ compiler flags. Since the parsing of the enum out of FUNCSIG relies on the precise format of this string, the calling convention needs to be __cdecl, or else the location of the ( )s is different than expected.
To fix my usage of magic_enum, I needed to add __cdecl to the instance on line 497, but I suspect that the other two functions that similarly parse these magic symbols also need this treatment to function properly on x86 under all possible default calling conventions, so I went ahead and fixed them as well.