Skip to content

PD: document how dynamic step edit form fields work #7296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IanLondon opened this issue Feb 8, 2021 · 1 comment
Closed

PD: document how dynamic step edit form fields work #7296

IanLondon opened this issue Feb 8, 2021 · 1 comment
Labels
docs protocol designer Affects the `protocol-designer` project

Comments

@IanLondon
Copy link
Contributor

PD's "dynamic" step edit forms are only presently used in the Thermocycler profile step. Since users can arbitrarily add and remove these fields, the typical "hard-wire the name into each UI component" approach we use for non-dynamic fields doesn't quite work here. For example, the way we do pristinity requires FocusHandlers to be passed down all the way into the component, and different utilities are used eg showProfileFieldErrors instead of showFieldErrors.

Since these fields function differently, they deserve documentation that outlines what goes into these fields and how they differ from normal non-dynamic form fields in PD.

@IanLondon IanLondon added protocol designer Affects the `protocol-designer` project docs 🕷️ SPDDRS labels Feb 8, 2021
@shlokamin shlokamin self-assigned this Apr 15, 2021
@shlokamin shlokamin removed their assignment Apr 27, 2021
@ecormany
Copy link
Contributor

Guessing PD redesign has obviated this.

@ecormany ecormany closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs protocol designer Affects the `protocol-designer` project
Projects
None yet
Development

No branches or pull requests

4 participants