Skip to content

feat(api): RobotContext add opentrons_simulate outputs #17040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025

Conversation

Laura-Danielle
Copy link
Contributor

Overview

Any movement related commands in the robot context should have run logs associated with them.

Test Plan and Hands on Testing

  1. Check that run logs get generated for robot commands.

Changelog

  • Add run logs to robot context commands

Review requests

Check that the run log messages make sense.

Risk assessment

Low. Adding run logs to un-used API.

@Laura-Danielle Laura-Danielle requested a review from a team as a code owner December 4, 2024 21:49
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, are we going to do the app too?

@sfoster1 sfoster1 force-pushed the EXEC-913-add-run-log-robot-context branch from fbf7276 to 0226d93 Compare April 25, 2025 15:41
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.57%. Comparing base (e40dc6f) to head (ab5afed).
Report is 4 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17040      +/-   ##
==========================================
- Coverage   23.57%   23.57%   -0.01%     
==========================================
  Files        3038     3038              
  Lines      254591   254602      +11     
  Branches    25634    25634              
==========================================
  Hits        60010    60010              
- Misses     194566   194577      +11     
  Partials       15       15              
Flag Coverage Δ
protocol-designer 19.00% <ø> (-0.01%) ⬇️
step-generation 4.38% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sfoster1 sfoster1 requested a review from a team as a code owner April 25, 2025 16:43
@sfoster1 sfoster1 changed the title feat(api): RobotContext add run log commands feat(api): RobotContext add opentrons_simulate outputs Apr 25, 2025
@sfoster1 sfoster1 merged commit 3782455 into edge Apr 25, 2025
69 checks passed
@sfoster1 sfoster1 deleted the EXEC-913-add-run-log-robot-context branch April 25, 2025 16:58
ddcc4 pushed a commit that referenced this pull request May 16, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
ddcc4 pushed a commit that referenced this pull request May 16, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
ddcc4 pushed a commit that referenced this pull request May 16, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
ddcc4 pushed a commit that referenced this pull request May 16, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 3782455)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
Any movement related commands in the robot context should have run logs
associated with them.

1. Check that run logs get generated for robot commands.

- Add run logs to robot context commands

Check that the run log messages make sense.

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 472d6f8b9317480707a23cf53ed0ff58fe348f25)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
Any movement related commands in the robot context should have run logs
associated with them.

1. Check that run logs get generated for robot commands.

- Add run logs to robot context commands

Check that the run log messages make sense.

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 5aa87c920f1cedf7845421da2721c25ad2cd612a)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 3782455)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 3782455)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 3782455)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 3782455)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 3782455)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 3782455)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 3782455)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 3782455)
ddcc4 pushed a commit that referenced this pull request May 22, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 3782455)
ddcc4 pushed a commit that referenced this pull request May 23, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 3782455)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 3782455)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
# Overview

Any movement related commands in the robot context should have run logs
associated with them.

## Test Plan and Hands on Testing

1. Check that run logs get generated for robot commands.

## Changelog

- Add run logs to robot context commands

## Review requests

Check that the run log messages make sense.

## Risk assessment

Low. Adding run logs to un-used API.

---------

Co-authored-by: Seth Foster <seth@opentrons.com>
(cherry picked from commit 3782455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants