-
Notifications
You must be signed in to change notification settings - Fork 184
feat(api): RobotContext add opentrons_simulate outputs #17040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, are we going to do the app too?
fbf7276
to
0226d93
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17040 +/- ##
==========================================
- Coverage 23.57% 23.57% -0.01%
==========================================
Files 3038 3038
Lines 254591 254602 +11
Branches 25634 25634
==========================================
Hits 60010 60010
- Misses 194566 194577 +11
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com>
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com>
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com>
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com>
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com>
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com>
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com>
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
Any movement related commands in the robot context should have run logs associated with them. 1. Check that run logs get generated for robot commands. - Add run logs to robot context commands Check that the run log messages make sense. Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 472d6f8b9317480707a23cf53ed0ff58fe348f25)
Any movement related commands in the robot context should have run logs associated with them. 1. Check that run logs get generated for robot commands. - Add run logs to robot context commands Check that the run log messages make sense. Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 5aa87c920f1cedf7845421da2721c25ad2cd612a)
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
Overview
Any movement related commands in the robot context should have run logs associated with them.
Test Plan and Hands on Testing
Changelog
Review requests
Check that the run log messages make sense.
Risk assessment
Low. Adding run logs to un-used API.