-
Notifications
You must be signed in to change notification settings - Fork 184
fix(protocol-designer) refactor cypress locators to be less brittle #17891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: edge
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17891 +/- ##
===========================================
- Coverage 61.91% 24.47% -37.45%
===========================================
Files 2950 2950
Lines 227584 227374 -210
Branches 19186 19095 -91
===========================================
- Hits 140902 55639 -85263
- Misses 86510 171723 +85213
+ Partials 172 12 -160
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
It would be awesome if we could get a test-id for all of our dropdown
I think it's in the following spots, but I haven't added a test-id yet.
What I think would be helpful as a more general statement is to evaluate how useful/time-consuming it would be to put test-IDs on all dropdown menus. |
…. These checkboxes, I think, should wait until after liquid classes since we are remaking the transfer step form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if it passes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took me so long to get to this. I will work on a PR for these locators next week.
Overview
Going through cypress typescript files to create stronger locators so tests will be less likely to break
Review requests
Risk assessment