Skip to content

test feat(protocol-designer): ff enable when pd isn't prod #18116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 18, 2025

Overview

ff enable when pd isn't prod

clsoe AUTH-

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

ff enable when pd isn't prod

clsoe AUTH-
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 25.61%. Comparing base (21aa9b0) to head (d62d065).
Report is 234 commits behind head on edge.

Files with missing lines Patch % Lines
protocol-designer/src/configureStore.ts 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18116      +/-   ##
==========================================
- Coverage   25.61%   25.61%   -0.01%     
==========================================
  Files        3015     3015              
  Lines      234489   234494       +5     
  Branches    20151    20151              
==========================================
  Hits        60057    60057              
- Misses     174417   174422       +5     
  Partials       15       15              
Flag Coverage Δ
protocol-designer 18.91% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol-designer/src/configureStore.ts 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji requested review from ncdiehl11 and jerader April 18, 2025 21:47
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@koji koji closed this May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants