-
Notifications
You must be signed in to change notification settings - Fork 184
feat(protocol-designer): introduce sentry #18153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test Sentry for error tracking close AUTH-1723
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18153 +/- ##
==========================================
- Coverage 23.76% 22.63% -1.14%
==========================================
Files 3038 3039 +1
Lines 253513 255892 +2379
Branches 23604 23798 +194
==========================================
- Hits 60252 57922 -2330
- Misses 193246 197961 +4715
+ Partials 15 9 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Thanks Koji! One more idea for part 2 of this: at my previous company, in our Python projects, we also added a hook that reported everything logged at level I wonder if the Sentry JavaScript API can do something similar. We have a lot of places in PD where we chose to |
@@ -47,6 +49,12 @@ export function ProtocolDesignerAppFallback({ | |||
dispatch(actions.saveProtocolFile()) | |||
} | |||
|
|||
useEffect(() => { | |||
if (error) { | |||
captureException(error, { extra: { errorId } }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not so familiar with this part of the code. Can you tell me if error
is a JavaScript exception here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, error is the captured JavaScript exception object provided by react-error-boundary
|
if what you mean is this, we can set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Overview
introduce Sentry to PD for better error tracking.
the usage of Sentry is similar to Mixpanel.
Sentry init is called when a user allows pd to track data (getHasOptedIn: true)
sent an invitation of Sentry to each reviewers
Test Plan and Hands on Testing
Changelog
Review requests
I add DEV_DNS as well as Mixpanel. Do we want to use Sentry for our dev environment (sandbox)
Risk assessment
low