-
Notifications
You must be signed in to change notification settings - Fork 184
feature(app, api): desktop odd labware not detected in labware shuttle #18156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(app, api): desktop odd labware not detected in labware shuttle #18156
Conversation
...anisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderContent/ActionButton/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple first pass things, also i think we should rebase on/merge in latest edge
api/src/opentrons/protocol_engine/commands/flex_stacker/close_latch.py
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18156 +/- ##
===========================================
- Coverage 57.53% 23.53% -34.01%
===========================================
Files 3039 3041 +2
Lines 254623 255190 +567
Branches 30448 25654 -4794
===========================================
- Hits 146507 60061 -86446
- Misses 107930 195114 +87184
+ Partials 186 15 -171
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
6bb31c9
to
b2dda8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks good! Just some cleanup.
All files in Error Recovery that are modified should have an equivalent test file that also gets modified, which would be nice to cover if time permits. I've marked some of the more important ones that would definitely be nice to get tests in for.
app/src/organisms/ErrorRecoveryFlows/shared/TwoColTextAndImage.tsx
Outdated
Show resolved
Hide resolved
app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/SelectRecoveryOption.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a test foreach error kind
Overview
closes https://opentrons.atlassian.net/browse/EXEC-1151 and https://opentrons.atlassian.net/browse/EXEC-1201
add the ability to use ER flows for labware stuck in the hopper by releasing and closing the latch.
Test Plan and Hands on Testing
upload the following protocol to the flex:
Changelog
Review requests
changes make sense?
Risk assessment
Medium. touching gripper release flow need to smoke test