Skip to content

feature(app, api): desktop odd labware not detected in labware shuttle #18156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TamarZanzouri
Copy link
Contributor

Overview

closes https://opentrons.atlassian.net/browse/EXEC-1151 and https://opentrons.atlassian.net/browse/EXEC-1201
add the ability to use ER flows for labware stuck in the hopper by releasing and closing the latch.

Test Plan and Hands on Testing

upload the following protocol to the flex:

requirements = {"robotType": "Flex", "apiLevel": "2.23"}


def run(protocol):
    stacker_c = protocol.load_module("flexStackerModuleV1", "C4")
    stacker_d = protocol.load_module("flexStackerModuleV1", "D4")
    stacker_c.set_stored_labware(load_name="opentrons_flex_96_tiprack_1000ul", count=5)

    tiprack = stacker_c.retrieve()
    stacker_c.store()
    stacker_c.empty(message="hello")
    stacker_c.fill(message="what")

Changelog

  • add a test that makes sure that the correct labware name is rendering (note to self)

Review requests

changes make sense?

Risk assessment

Medium. touching gripper release flow need to smoke test

@TamarZanzouri TamarZanzouri requested review from a team as code owners April 22, 2025 20:57
@TamarZanzouri TamarZanzouri requested review from ncdiehl11, sfoster1, smb2268 and mjhuff and removed request for a team and ncdiehl11 April 22, 2025 20:57
@TamarZanzouri TamarZanzouri marked this pull request as draft April 22, 2025 20:59
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple first pass things, also i think we should rebase on/merge in latest edge

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 454 lines in your changes missing coverage. Please review.

Project coverage is 23.53%. Comparing base (9e81f8f) to head (31ce8cd).
Report is 1 commits behind head on edge.

Files with missing lines Patch % Lines
app/src/organisms/ErrorRecoveryFlows/constants.ts 0.00% 115 Missing ⚠️
...rganisms/ErrorRecoveryFlows/RecoveryInProgress.tsx 0.00% 85 Missing ⚠️
...s/ErrorRecoveryFlows/shared/TwoColTextAndImage.tsx 0.00% 62 Missing ⚠️
...ms/ErrorRecoveryFlows/hooks/useRecoveryCommands.ts 0.00% 60 Missing ⚠️
...yFlows/RecoveryOptions/ManualReplaceLwAndRetry.tsx 0.00% 33 Missing ⚠️
...nisms/ErrorRecoveryFlows/shared/ReleaseLabware.tsx 0.00% 32 Missing ⚠️
...nisms/ErrorRecoveryFlows/shared/HoldingLabware.tsx 0.00% 25 Missing ⚠️
.../ErrorRecoveryFlows/shared/TwoColLwInfoAndDeck.tsx 0.00% 14 Missing ⚠️
...veryFlows/RecoveryOptions/SelectRecoveryOption.tsx 0.00% 6 Missing ⚠️
...ErrorRecoveryFlows/hooks/useRecoveryOptionCopy.tsx 0.00% 4 Missing ⚠️
... and 8 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #18156       +/-   ##
===========================================
- Coverage   57.53%   23.53%   -34.01%     
===========================================
  Files        3039     3041        +2     
  Lines      254623   255190      +567     
  Branches    30448    25654     -4794     
===========================================
- Hits       146507    60061    -86446     
- Misses     107930   195114    +87184     
+ Partials      186       15      -171     
Flag Coverage Δ
app 3.13% <0.00%> (-44.51%) ⬇️
protocol-designer 18.97% <0.00%> (-0.04%) ⬇️
shared-data 73.93% <ø> (+0.40%) ⬆️
step-generation 4.37% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...p/src/organisms/ErrorRecoveryFlows/shared/index.ts 0.00% <ø> (-100.00%) ⬇️
app/src/organisms/ErrorRecoveryFlows/types.ts 100.00% <ø> (ø)
.../useCommandTextString/utils/getLabwareLocation.tsx 27.35% <ø> (-0.82%) ⬇️
.../ErrorRecoveryFlows/hooks/useFailedLabwareUtils.ts 0.00% <0.00%> (-75.40%) ⬇️
...isms/ErrorRecoveryFlows/hooks/useRecoveryToasts.ts 0.00% <0.00%> (-80.00%) ⬇️
...overyFlows/RecoveryOptions/ManualMoveLwAndSkip.tsx 0.00% <0.00%> (-100.00%) ⬇️
...organisms/ErrorRecoveryFlows/hooks/useErrorName.ts 0.00% <0.00%> (-100.00%) ⬇️
...organisms/ErrorRecoveryFlows/utils/getErrorKind.ts 0.00% <0.00%> (-100.00%) ⬇️
...ganisms/ErrorRecoveryFlows/ErrorRecoveryWizard.tsx 0.00% <0.00%> (-92.83%) ⬇️
...ganisms/ErrorRecoveryFlows/shared/SkipStepInfo.tsx 0.00% <0.00%> (-95.30%) ⬇️
... and 11 more

... and 1636 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TamarZanzouri TamarZanzouri force-pushed the EXEC-1151-desktop-odd-labware-not-detected-in-labware-shuttle branch from 6bb31c9 to b2dda8f Compare April 23, 2025 18:35
@TamarZanzouri TamarZanzouri marked this pull request as ready for review April 23, 2025 19:53
@TamarZanzouri TamarZanzouri requested a review from sfoster1 April 23, 2025 19:53
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks good! Just some cleanup.

All files in Error Recovery that are modified should have an equivalent test file that also gets modified, which would be nice to cover if time permits. I've marked some of the more important ones that would definitely be nice to get tests in for.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a test foreach error kind

@TamarZanzouri TamarZanzouri merged commit 66197e1 into edge Apr 26, 2025
80 of 82 checks passed
@TamarZanzouri TamarZanzouri deleted the EXEC-1151-desktop-odd-labware-not-detected-in-labware-shuttle branch April 26, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants