Skip to content

refactor(api, shared-data): update stacker commands to unsafe #18157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 25, 2025

Conversation

ahiuchingau
Copy link
Contributor

Overview

Sets the flexStacker/prepareShuttle, closeLatch and openLatch commands as unsafe commands.

We don't have to update schema 12 too, right?

@ahiuchingau ahiuchingau requested review from a team as code owners April 22, 2025 21:12
@ahiuchingau ahiuchingau requested review from jerader and removed request for a team April 22, 2025 21:12
@ahiuchingau ahiuchingau force-pushed the EXEC-1439_stacker-unsafe-commands branch from 8f291dd to e82411f Compare April 22, 2025 21:12
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 23.46%. Comparing base (3329159) to head (c29c933).
Report is 3 commits behind head on edge.

Files with missing lines Patch % Lines
app/src/organisms/ModuleCard/hooks.tsx 0.00% 2 Missing ⚠️
...ms/ErrorRecoveryFlows/hooks/useRecoveryCommands.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18157      +/-   ##
==========================================
+ Coverage   21.53%   23.46%   +1.92%     
==========================================
  Files        3038     3038              
  Lines      254518   255762    +1244     
  Branches    25662    24198    -1464     
==========================================
+ Hits        54813    60012    +5199     
+ Misses     199692   195735    -3957     
- Partials       13       15       +2     
Flag Coverage Δ
protocol-designer 19.01% <0.00%> (ø)
step-generation 4.38% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ms/ErrorRecoveryFlows/hooks/useRecoveryCommands.ts 0.00% <0.00%> (ø)
app/src/organisms/ModuleCard/hooks.tsx 0.00% <0.00%> (ø)

... and 378 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ahiuchingau ahiuchingau force-pushed the EXEC-1439_stacker-unsafe-commands branch from ee73489 to b82a9fd Compare April 23, 2025 14:17
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Re schema 12: I think it's reasonable to leave it as-is, but you could also delete these commands from it, since it sounds like we consider these commands to have not been stable and usable back then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're calling these commands unsafe, I'd appreciate docstrings somewhere that explain why they're unsafe. Like, from the perspective of someone sending commands to the robot, what are the caveats about these, why shouldn't these be used in protocols, and what are the preconditions/postconditions to use these properly.

@ahiuchingau ahiuchingau merged commit 9e81f8f into edge Apr 25, 2025
72 of 73 checks passed
@ahiuchingau ahiuchingau deleted the EXEC-1439_stacker-unsafe-commands branch April 25, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants