Chore: Incremental mergeback of PD chore release 8.4.4 into edge #18170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts JSON key to match (#17385) closes AUTH-1382 This PR introduces `liquidEntities` to `InvariantContext` so step-generation will have access to liquids and the liquid `pythonName`. As a result, the previous selector that stored liquid info, `allIngredientNamesIds` has been deprecated. Additionally, `pythonName` is assigned during liquid creation via the `EDIT_LIQUID_GROUP` action and if a user deletes a liquid, the `deleteLiquidGroup` thunk is called which: deletes the liquid, edits all subsequent liquids with the new `liquidEntities` object.
closes AUTH-1396 The goal of this PR is so when importing JSON/python protocols back into PD, we can determine the additionalEquipment entities from `stepForms` instead of reading the commands. This PR introduces a few new `-locationUpdate` keys in `savedStepForms`'s `INITIAL_DECK_SETUP_STEP` step. The locations include: - `trashBinLocationUpdate` - `wasteChuteLocationUpdate` - `gripperLocationUpdate` - `stagingAreaLocationUpdate`
#17432) …odules keys closes AUTH-1407 This PR introduces `designerApplication` top level keys for `modules`, `labware`, and `pipettes`. Then when you import a protocol, the migration will grab that info from the load commands and the `load-file` reducer will use that info to populate the `labwareEntities`, `pipetteEntities`, and `moduleEntities`. Additionally, this pr deprecates the `defaultValues` key that was not in use at all
…o each entity (#17463) closes AUTH-1383 For python/pd interop, we want to add a `pythonName` to `liquidEntity`, `labwareEntity`, `moduleEntity`, and `pipetteEntity`. This PR does that by adding them in redux, that way, the `pythonName` is not polluting the JSON structure. For Quick Transfer, the `pythonName` is generated in `generateQuickTransferArgs`. The python name patterning is as follows: - modules: moduleType minus `Type` in snake case plus the number so `heater_shaker_module_1` and then `heater_shaker_module_2` for 2 heater-shaker modules - pipettes: `pipette_left` or `pipette_right` - labware: the labware displayCategory in snake case plus the number. So 2 well plates and 1 reservoir would be `well_plate_1`, `well_plate_2`, `reservoir_1` - liquids: just liquid with the number so `liquid_1`, `liquid_2`, etc.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18170 +/- ##
===========================================
+ Coverage 24.95% 57.95% +32.99%
===========================================
Files 3032 3035 +3
Lines 235532 252734 +17202
Branches 20161 27717 +7556
===========================================
+ Hits 58780 146475 +87695
+ Misses 176738 106074 -70664
- Partials 14 185 +171
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jerader
changed the title
ddcc4
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
incremental chore_release-pd-8.4.4 mergeback into edge. Starting from
alpha.0so the 8.4.4 migration file can be in edge