chore: Fix wildcards in GitHub Actions workflows #18172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18172 +/- ##
===========================================
- Coverage 57.95% 25.24% -32.71%
===========================================
Files 3035 3100 +65
Lines 252734 257210 +4476
Branches 27717 19966 -7751
===========================================
- Hits 146475 64945 -81530
- Misses 106074 192245 +86171
+ Partials 185 20 -165
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sfoster1
approved these changes
Apr 24, 2025
SyntaxColoring
added a commit
to Opentrons/buildroot
that referenced
this pull request
May 16, 2025
Same thing as Opentrons/opentrons#18172. Some existing wildcards in our GitHub actions are not matching the `/` character, and I think that's causing CI to not run on Dependabot PRs like #244 because they have `/` in the branch name.
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py`
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py`
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py`
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py`
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py`
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py`
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py`
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py`
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py`
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
ddcc4
pushed a commit
that referenced
this pull request
May 20, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
ddcc4
pushed a commit
that referenced
this pull request
May 20, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
ddcc4
pushed a commit
that referenced
this pull request
May 22, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
ddcc4
pushed a commit
that referenced
this pull request
May 23, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
ddcc4
pushed a commit
that referenced
this pull request
May 24, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
ddcc4
pushed a commit
that referenced
this pull request
May 24, 2025
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should. For instance: `*` looks like it's meant to match everything, but for that, we really want `**`, otherwise we fail to match things that contain slashes. `dir1/**/*.py` looks like it's meant to match any `.py` file under `dir1/`, but I think it will only match things like `dir1/dir2/file.py` and `dir1/dir2/dir3/file.py`, and fail to match things like `dir1/file.py` (cherry picked from commit 3c8b7fa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes what I suspect are mistakes in our GitHub Actions workflows, which, in edge cases, could cause problems like workflows not triggering when they should.
For instance:
*looks like it's meant to match everything, but for that, we really want**, otherwise we fail to match things that contain slashes.dir1/**/*.pylooks like it's meant to match any.pyfile underdir1/, but I think it will only match things likedir1/dir2/file.pyanddir1/dir2/dir3/file.py, and fail to match things likedir1/file.pyTest Plan and Hands on Testing
It's difficult to test this. I've tried to confirm my suspicions about how
foo/**/*.pyworks by pushing to a test branch and watching GitHub not trigger a workflow, but it's possible that there are other reasons that GitHub didn't trigger it.Review requests
Does this seem right, given the documentation and any anecdotal experience you have with GitHub wildcards?
Risk assessment
Medium.