Skip to content

fix(api): raise error if specified labware count exceeds max capacity during stacker fill/set stored labware #18174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2025

Conversation

ahiuchingau
Copy link
Contributor

This PR refactors the the hopper labware counting logic for the Flex Stacker module. The changes focus on simplifying the _count_from_lw_list_or_initial_count function by making sure we're raising the appropriate error if the specified labware count or labware list exceeds the stacker's max capacity.

@ahiuchingau ahiuchingau requested a review from a team as a code owner April 24, 2025 20:39
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, love the simplification. Sorry about the amount of tests lol

@ahiuchingau ahiuchingau merged commit ed08842 into edge Apr 25, 2025
24 checks passed
@ahiuchingau ahiuchingau deleted the EXEC-1452 branch April 25, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants