Skip to content

feat(api): For the Flex Stacker only set run/ihold current if they are actually different #18175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2025

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Apr 24, 2025

Overview

We don't always have to send the run/ihold current if they were not changed for the given axis, so let's not.

Test Plan and Hands on Testing

  • Make sure we only set the run/hold current if they are different from what we have recorded

Changelog

  • Store the run, hold currents, and only send the GCODE command down the wire if the values differ.

Review requests

Risk assessment

Low, unreleased

@vegano1 vegano1 requested a review from a team as a code owner April 24, 2025 20:56
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests please

@vegano1 vegano1 requested review from sfoster1 and ahiuchingau April 29, 2025 16:03
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah nice catch!

@vegano1 vegano1 merged commit 07130f8 into edge Apr 29, 2025
24 checks passed
@vegano1 vegano1 deleted the flex-stacker-mitigate-no-response branch April 29, 2025 18:37
vegano1 added a commit that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants