Skip to content

refactor(labware-library, app, shared-data): add adapter/labware comb… #18180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Apr 25, 2025

…os to retired labware

closes RQA-4107

Overview

Update both Labware-library and App Labware to include Retired in labware definition display names that are listed in the RETIRED_LABWARE list and add the adapter/labware combos to the retired list.

Test Plan and Hands on Testing

Search for Retired labware in Labware-library and when you click on the labware card, the labware details should show retired as well. And then do the same for the App Labware

Changelog

  • add the adapter/labware combo defs to the retired list
  • use getLabwareDisplayName util in Labware-library and App Labware's LabwareCard and LabwareDetails

Risk assessment

low, just adding retired to a few labware display names

@jerader jerader requested review from a team as code owners April 25, 2025 13:14
@jerader jerader requested review from smb2268, SyntaxColoring, koji and ncdiehl11 and removed request for a team April 25, 2025 13:14
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 23.65%. Comparing base (a74a574) to head (5b57523).
Report is 4 commits behind head on edge.

Files with missing lines Patch % Lines
...organisms/Desktop/Labware/LabwareDetails/index.tsx 0.00% 3 Missing ⚠️
...ary/src/components/LabwareDetails/LabwareTitle.tsx 0.00% 3 Missing ⚠️
...library/src/components/LabwareList/LabwareCard.tsx 0.00% 3 Missing ⚠️
...rc/organisms/Desktop/Labware/LabwareCard/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18180      +/-   ##
==========================================
- Coverage   23.76%   23.65%   -0.12%     
==========================================
  Files        3038     3038              
  Lines      253513   253392     -121     
  Branches    23604    24033     +429     
==========================================
- Hits        60252    59941     -311     
- Misses     193246   193436     +190     
  Partials       15       15              
Flag Coverage Δ
protocol-designer 18.99% <33.33%> (+<0.01%) ⬆️
step-generation 4.38% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
shared-data/js/helpers/index.ts 54.21% <100.00%> (-6.15%) ⬇️
...rc/organisms/Desktop/Labware/LabwareCard/index.tsx 0.00% <0.00%> (ø)
...organisms/Desktop/Labware/LabwareDetails/index.tsx 0.00% <0.00%> (ø)
...ary/src/components/LabwareDetails/LabwareTitle.tsx 0.00% <0.00%> (ø)
...library/src/components/LabwareList/LabwareCard.tsx 0.00% <0.00%> (ø)

... and 128 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jerader jerader merged commit e40dc6f into edge Apr 25, 2025
70 checks passed
@jerader jerader deleted the app_ll-retired-lw branch April 25, 2025 14:53
ecormany added a commit that referenced this pull request Apr 25, 2025
# Overview

Python API docs PR corresponding to changes in #18180. 

## Test Plan and Hands on Testing


[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil
ddcc4 pushed a commit that referenced this pull request May 16, 2025
# Overview

Python API docs PR corresponding to changes in #18180. 

## Test Plan and Hands on Testing


[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil
ddcc4 pushed a commit that referenced this pull request May 16, 2025
# Overview

Python API docs PR corresponding to changes in #18180. 

## Test Plan and Hands on Testing


[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil
ddcc4 pushed a commit that referenced this pull request May 16, 2025
# Overview

Python API docs PR corresponding to changes in #18180. 

## Test Plan and Hands on Testing


[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil
ddcc4 pushed a commit that referenced this pull request May 16, 2025
# Overview

Python API docs PR corresponding to changes in #18180. 

## Test Plan and Hands on Testing


[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil
ddcc4 pushed a commit that referenced this pull request May 16, 2025
# Overview

Python API docs PR corresponding to changes in #18180. 

## Test Plan and Hands on Testing


[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil
ddcc4 pushed a commit that referenced this pull request May 16, 2025
# Overview

Python API docs PR corresponding to changes in #18180. 

## Test Plan and Hands on Testing


[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Python API docs PR corresponding to changes in #18180. 

## Test Plan and Hands on Testing


[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Python API docs PR corresponding to changes in #18180. 

## Test Plan and Hands on Testing


[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Python API docs PR corresponding to changes in #18180. 

## Test Plan and Hands on Testing


[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 22, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 23, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
# Overview

Python API docs PR corresponding to changes in #18180.

## Test Plan and Hands on Testing

[Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together)

## Changelog

- Moves all mention of combination adapters into a note.
- Indicates that they are deprecated as of API version 2.15 (which they
effectively have been, even if we didn't strongly discourage their use).
- List a couple features that will not work with them and say that
future features are also not guaranteed.

## Review requests

just accuracy

## Risk assessment

nil

(cherry picked from commit ec1ec02)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants