-
Notifications
You must be signed in to change notification settings - Fork 184
refactor(labware-library, app, shared-data): add adapter/labware comb… #18180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os to retired labware closes RQA-4107
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18180 +/- ##
==========================================
- Coverage 23.76% 23.65% -0.12%
==========================================
Files 3038 3038
Lines 253513 253392 -121
Branches 23604 24033 +429
==========================================
- Hits 60252 59941 -311
- Misses 193246 193436 +190
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
koji
approved these changes
Apr 25, 2025
ecormany
added a commit
that referenced
this pull request
Apr 25, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 20, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 20, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 22, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 23, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 24, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 24, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
# Overview Python API docs PR corresponding to changes in #18180. ## Test Plan and Hands on Testing [Sandbox](http://sandbox.docs.opentrons.com/docs-combo-adapters-retired/v2/new_labware.html#loading-together) ## Changelog - Moves all mention of combination adapters into a note. - Indicates that they are deprecated as of API version 2.15 (which they effectively have been, even if we didn't strongly discourage their use). - List a couple features that will not work with them and say that future features are also not guaranteed. ## Review requests just accuracy ## Risk assessment nil (cherry picked from commit ec1ec02)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…os to retired labware
closes RQA-4107
Overview
Update both Labware-library and App Labware to include
Retired
in labware definition display names that are listed in theRETIRED_LABWARE
list and add the adapter/labware combos to the retired list.Test Plan and Hands on Testing
Search for Retired labware in Labware-library and when you click on the labware card, the labware details should show retired as well. And then do the same for the App Labware
Changelog
getLabwareDisplayName
util in Labware-library and App Labware's LabwareCard and LabwareDetailsRisk assessment
low, just adding
retired
to a few labware display names