refactor(app, api): Extend Error Recovery Policies to "fixit" commands

[mjhuff]

Closes RQA-4121

Overview

If a user performs a recovery flow and chooses to ignore an error type, and then re-enters Error Recovery at a later time (for a different error), we should probably apply existing error recovery policies to fixit commands.

As a concrete example, this can happen when a user ignores tip pick up errors, enters Error Recovery for something like an overpressure error, and then attempts to pick up a tip during the flow.

Current Behavior

Screen.Recording.2025-04-24.at.4.57.52.PM.mov

Updated Behavior

Screen.Recording.2025-04-24.at.4.56.03.PM.mov

Test Plan and Hands on Testing

• See videos

Changelog

• Failing a recovery command during error recovery that is associated with an existing error recovery policy correctly ignores the error.

Review requests

• I think we only need to update the CommandStore in api, but is there anywhere else I may have missed?

Risk assessment

• low...maybe? It seems better to target edge here instead of chore_release, just so we can dogfood this a bit. It doesn't seem critical enough to include at this stage in 8.4, anyway.

[sfoster1]

Interesting. I like it in concept and think it is the right thing to do. This just lets you continue ER without further popups (well, restarting it) but does not vector you into ER for the failed fixit command in the UI right?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 22.80%. Comparing base (603ebd0) to head (47a58da).
Report is 1 commits behind head on edge.

Files with missing lines	Patch %	Lines
...s/utils/shouldCommandSucceedGivenRecoveryPolicy.ts	0.00%	22 Missing ⚠️
app/src/resources/runs/utils.ts	0.00%	7 Missing ⚠️
...ms/ErrorRecoveryFlows/hooks/useRecoveryCommands.ts	0.00%	6 Missing ⚠️
app/src/resources/runs/hooks.ts	0.00%	4 Missing ⚠️
app/src/local-resources/commands/utils/index.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             edge   #18184      +/-   ##
==========================================
- Coverage   23.56%   22.80%   -0.76%     
==========================================
  Files        3038     3039       +1     
  Lines      254563   254553      -10     
  Branches    25633    25662      +29     
==========================================
- Hits        59990    58063    -1927     
- Misses     194558   196476    +1918     
+ Partials       15       14       -1     

Flag	Coverage Δ
app	2.28% <0.00%> (-0.88%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
app/src/local-resources/commands/utils/index.ts	0.00% <0.00%> (ø)
app/src/resources/runs/hooks.ts	0.00% <0.00%> (ø)
...ms/ErrorRecoveryFlows/hooks/useRecoveryCommands.ts	0.00% <0.00%> (ø)
app/src/resources/runs/utils.ts	0.00% <0.00%> (ø)
...s/utils/shouldCommandSucceedGivenRecoveryPolicy.ts	0.00% <0.00%> (ø)

... and 62 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mjhuff]

This just lets you continue ER without further popups (well, restarting it) but does not vector you into ER for the failed fixit command in the UI right?

Yes, exactly. The error is silently ignored.