Skip to content

refactor(protocol-deisgner): addFixtureModal in a portal #18190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Apr 28, 2025

Overview

AddFixtureModal wasn't wrapped in a portal

Before:
Screenshot 2025-04-28 at 10 18 44

After:
Screenshot 2025-04-28 at 10 18 25

Test Plan and Hands on Testing

Check code, you can smoke test too between edge and this branch

Changelog

wrap modal in a portal

Risk assessment

low

@jerader jerader requested a review from a team as a code owner April 28, 2025 14:19
@jerader jerader requested review from koji and ncdiehl11 April 28, 2025 14:19
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.40%. Comparing base (f19e3f8) to head (4569edf).
Report is 3 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18190      +/-   ##
==========================================
+ Coverage   57.38%   57.40%   +0.02%     
==========================================
  Files        3041     3041              
  Lines      255229   255286      +57     
  Branches    30430    30470      +40     
==========================================
+ Hits       146457   146546      +89     
+ Misses     108586   108554      -32     
  Partials      186      186              
Flag Coverage Δ
protocol-designer 19.00% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...organisms/HardwareConfigurator/AddFixtureModal.tsx 72.52% <100.00%> (+0.20%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jerader jerader merged commit baec90e into edge Apr 28, 2025
26 checks passed
@jerader jerader deleted the pd_main-portal branch April 28, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants