Skip to content

refactor(api): Delete unused SIMULATED sentinel #18191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

refactor(api): Delete unused SIMULATED sentinel #18191

merged 1 commit into from
Apr 28, 2025

Conversation

SyntaxColoring
Copy link
Contributor

Overview

This deletes the opentrons.protocol_engine.state.update_types.SIMULATED sentinel object, which was not used for anything.

Test Plan and Hands on Testing

Just CI.

Review requests

Any reason to keep this?

Risk assessment

No risk if CI passes.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner April 28, 2025 14:57
@SyntaxColoring SyntaxColoring changed the title refactor(api): Delete unused SIMULATED sentine refactor(api): Delete unused SIMULATED sentinel Apr 28, 2025
sfoster1
sfoster1 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no reason not to, ended up not being used because it couldn't actually be contained to the engine internals

@SyntaxColoring
Copy link
Contributor Author

Failing CI is unrelated to this PR (it's a problem in edge).

@SyntaxColoring SyntaxColoring merged commit d0499e1 into edge Apr 28, 2025
26 of 27 checks passed
@SyntaxColoring SyntaxColoring deleted the delete_dead_simulated_code branch April 28, 2025 15:24
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
25f4e8f 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
2a58473 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
46f9531 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
5314cd2 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
44c3d3a 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
70c7818 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
1b5e5b6 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.
@ddcc4 ddcc4 mentioned this pull request May 17, 2025
Open
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
299010f 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
15ba509 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
f35a1e0 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
e194d0b 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
391bfa6 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
4e9eed4 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
98c0bf3 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
8bf9852 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
8a38ce2 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
f070e5a 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
2b5a7dd 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
d97c5ec 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
958a537 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
ddcc4 pushed a commit that referenced this pull request May 22, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
d951c6e 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
ddcc4 pushed a commit that referenced this pull request May 23, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
1177ce4 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
4c61de8 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
@SyntaxColoring @ddcc4
refactor(api): Delete unused SIMULATED sentinel (#18191)
68305b8 
This deletes the `opentrons.protocol_engine.state.update_types.SIMULATED` sentinel object, which was not used for anything.

(cherry picked from commit d0499e1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1

@caila-marashaj caila-marashaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SyntaxColoring @sfoster1