Skip to content

fix(app): add "manual fill" recovery success toasts #18192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Apr 28, 2025

Overview

After updating the "liquid not detected" recovery flows for meniscus pipetting support, I did not add all routes to the recovery success toast wire-up interface (a route recently refactored for the static meniscus changes is in the wrong toast type, too). This PR does that, and more importantly, testing now fails if an added recovery route does not explicitly have a toast associated with it (or is explicitly marked as a "null toast"), so this shouldn't happen again.

Test Plan and Hands on Testing

  • Covered by testing.

Review requests

  • Is there any reason we wouldn't want this in 8.4 at this stage? Seems ok, since we're cutting another alpha anyway.

Changelog

  • "No liquid detected" recovery options now properly display the correct toasts.

Risk assessment

basically none

@mjhuff mjhuff requested a review from a team as a code owner April 28, 2025 15:48
Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjhuff mjhuff merged commit a1aa7e6 into chore_release-8.4.0 Apr 28, 2025
30 checks passed
@mjhuff mjhuff deleted the app_no-liquid-detected-toast branch April 28, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants