Skip to content

feat(step-generation): add python to aspirateInPlace #18200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

ncdiehl11
Copy link
Collaborator

Overview

This PR adds Python code to the aspirateInPlace step-generation atomic command creator. Note that there is no separate aspirate_in_place Python API method— rather, the in place behavior is determined by the intentional omission of a location param to the aspirate method.

Test Plan and Hands on Testing

  • review code and make sure this aligns with how we handle aspirate in place in Python API

Changelog

  • update aspirateInPlace command creator and test

Review requests

--

Risk assessment

low

This PR adds Python code to the `aspirateInPlace` step-generation atomic command creator.
@ncdiehl11 ncdiehl11 self-assigned this Apr 29, 2025
@ncdiehl11 ncdiehl11 requested review from ddcc4 and jerader April 29, 2025 14:59
@ncdiehl11 ncdiehl11 marked this pull request as ready for review April 29, 2025 14:59
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner April 29, 2025 14:59
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.52%. Comparing base (2a32194) to head (af20f06).
Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #18200   +/-   ##
=======================================
  Coverage   57.52%   57.52%           
=======================================
  Files        3043     3043           
  Lines      255340   255350   +10     
  Branches    30544    30544           
=======================================
+ Hits       146879   146889   +10     
  Misses     108275   108275           
  Partials      186      186           
Flag Coverage Δ
protocol-designer 18.98% <9.09%> (-0.01%) ⬇️
step-generation 4.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tion/src/commandCreators/atomic/aspirateInPlace.ts 97.05% <100.00%> (+1.22%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ncdiehl11 ncdiehl11 removed the request for review from a team April 29, 2025 15:04
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ncdiehl11 ncdiehl11 merged commit 2ea61a9 into edge Apr 29, 2025
18 checks passed
@ncdiehl11 ncdiehl11 deleted the sg_feat-aspirateInPlace-python branch April 29, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants