Skip to content

refactor(protocol-designer): change from map to switch statement in multple-step slideout #18202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

koji
Copy link
Contributor

@koji koji commented Apr 29, 2025

Overview

change from map to switch statement in multple-step slideout
close AUTH-1787

multiple-step-toolbox.mov

Test Plan and Hands on Testing

  • create/import a protocol
  • go to Designer page
  • add liquid
  • edit transfer step without turning on liquid classes ff
    check the number of steps is 2
  • go to settings and turn on liquid classese ff
  • edit transfer again
    check the number of steps is 3

Changelog

Review requests

Risk assessment

low

…oolbox

change from map to switch statement in toolbox

close AUTH-
@koji koji requested review from ncdiehl11 and jerader April 29, 2025 15:21
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 76.31579% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.52%. Comparing base (2a32194) to head (85c8628).
Report is 8 commits behind head on edge.

Files with missing lines Patch % Lines
...Steps/StepForm/StepTools/MoveLiquidTools/index.tsx 76.31% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18202      +/-   ##
==========================================
- Coverage   57.52%   57.52%   -0.01%     
==========================================
  Files        3043     3043              
  Lines      255340   255347       +7     
  Branches    30544    30543       -1     
==========================================
+ Hits       146879   146883       +4     
- Misses     108275   108278       +3     
  Partials      186      186              
Flag Coverage Δ
protocol-designer 18.98% <76.31%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Steps/StepForm/StepTools/MoveLiquidTools/index.tsx 72.85% <76.31%> (-1.75%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji marked this pull request as ready for review April 29, 2025 15:27
@koji koji requested a review from a team as a code owner April 29, 2025 15:27
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@koji koji merged commit d9fa3d9 into edge Apr 30, 2025
26 checks passed
@koji koji deleted the refactor_multiple-steps-toolbox branch April 30, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants