feat(app): Add Submerge screen to QT Aspirate and Dispense #18209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add submerge to quick transfer for liquid classes close AUTH-
koji
commented
Apr 29, 2025
Comment on lines
+191
to
+219
| <> | ||
| <Flex | ||
| width="30.5rem" | ||
| height="100%" | ||
| gridGap={SPACING.spacing24} | ||
| flexDirection={DIRECTION_COLUMN} | ||
| marginTop={SPACING.spacing68} | ||
| > | ||
| <StyledText oddStyle="level4HeaderRegular"> | ||
| {t('submerge_aspirating_description')} | ||
| </StyledText> | ||
| <InputField type="number" value={speed} title={t('speed')} readOnly /> | ||
| </Flex> | ||
| <Flex | ||
| paddingX={SPACING.spacing24} | ||
| height="21.25rem" | ||
| marginTop="7.75rem" | ||
| borderRadius="0" | ||
| > | ||
| <NumericalKeyboard | ||
| key={`${kind}_speed_keyboard`} | ||
| keyboardRef={keyboardRef} | ||
| initialValue={String(speed ?? '')} | ||
| onChange={e => { | ||
| setSpeed(Number(e)) | ||
| }} | ||
| /> | ||
| </Flex> | ||
| </> |
There was a problem hiding this comment.
Using this because of https://opentrons.slack.com/archives/C07JJA1AJFQ/p1745864136081549
once i sync with Sue, i think i would be able to make a common component for the main part (input field + numerical keyboard) and reduce redundancy of this part (including the following one)
For size, there is diff between Primary design and the currnet prod. this pr aligns with the currnet prod size. I will disscuss this with Sue.
jerader
reviewed
May 1, 2025
app/src/organisms/ODD/QuickTransferFlow/Aspirate/hooks/useAspirateSettingsConfig.ts
Outdated
Show resolved
Hide resolved
jerader
reviewed
May 1, 2025
app/src/organisms/ODD/QuickTransferFlow/Dispense/hooks/useDispenseSettingsConfig.ts
Outdated
Show resolved
Hide resolved
jerader
reviewed
May 1, 2025
| onClickBack={handleClickBackOrExit} | ||
| onClickButton={handleClickSaveOrContinue} | ||
| top={SPACING.spacing8} | ||
| // buttonIsDisabled={buttonIsDisabled} |
There was a problem hiding this comment.
oh, i forgot to update the disabled.
i will update this.
jerader
reviewed
May 1, 2025
| @@ -53,23 +53,23 @@ describe('SelectPipettePath', () => { | |||
| screen.getByText('Single transfers') | |||
| }) | |||
|
|
|||
| it('should render sinle transfer when transfer is 1:n', () => { | |||
| it('should render single transfer when transfer is 1:n', () => { | |||
jerader
reviewed
May 1, 2025
| @@ -95,7 +95,7 @@ export function Delay(props: DelayProps): JSX.Element { | |||
| trackEventWithRobotSerial({ | |||
| name: ANALYTICS_QUICK_TRANSFER_SETTING_SAVED, | |||
| properties: { | |||
| settting: `Delay_${kind}`, | |||
There was a problem hiding this comment.
nice catch here too, i guess this has been affecting mixpanel
jerader
reviewed
May 1, 2025
| @@ -144,7 +144,7 @@ export function BlowOut(props: BlowOutProps): JSX.Element { | |||
| trackEventWithRobotSerial({ | |||
| name: ANALYTICS_QUICK_TRANSFER_SETTING_SAVED, | |||
| properties: { | |||
| settting: `BlowOut`, | |||
jerader
approved these changes
May 1, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18209 +/- ##
==========================================
+ Coverage 57.53% 57.72% +0.18%
==========================================
Files 3039 3044 +5
Lines 254623 256455 +1832
Branches 30448 30890 +442
==========================================
+ Hits 146507 148036 +1529
- Misses 107930 108236 +306
+ Partials 186 183 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
add Submerge to QuickTransfer's Aspirate tab and Dispense Tab
close AUTH-913 and AUTH-914
Test Plan and Hands on Testing
Changelog
useReducerReview requests
Risk assessment
low