-
Notifications
You must be signed in to change notification settings - Fork 184
feat(analyses-snapshot-testing): adding an OT-2 PD test to battery #18211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: edge
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the lint error:
cd analyses-snapshot-testing && \
make setup && \
make format
To get CI to open a PR to create the snapshot, I added the label to the PR :)
You should then see a comment about the PR opened into this branch.
If it looks good merge it, wait for everything to pass then you are good.
Approved once all ✅.
A PR has been opened to address analyses snapshot changes. Please review the changes here: #18213 |
https://github.com/Opentrons/opentrons/pull/18213/files#r2070302421 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18211 +/- ##
=======================================
Coverage 57.48% 57.48%
=======================================
Files 3043 3043
Lines 255276 255276
Branches 30517 30517
=======================================
Hits 146756 146756
Misses 108333 108333
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #18213 |
Overview
Adding of a snapshot test to edge
Test Plan and Hands on Testing
N/a
Changelog
Updated
analysis-snapshot-testing
to include OT-2 smoke testReview requests
@y3rsh
Risk assessment
Low