Skip to content

feat(analyses-snapshot-testing): adding an OT-2 PD test to battery #18211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: edge
Choose a base branch
from

Conversation

alexjoel42
Copy link
Contributor

Overview

Adding of a snapshot test to edge

Test Plan and Hands on Testing

N/a

Changelog

Updated analysis-snapshot-testing to include OT-2 smoke test

Review requests

@y3rsh

Risk assessment

Low

@alexjoel42 alexjoel42 requested review from a team as code owners April 30, 2025 15:57
@alexjoel42 alexjoel42 requested a review from y3rsh April 30, 2025 16:35
@alexjoel42 alexjoel42 changed the title test(add 8.4.4 pd test to battery): adding an OT-2 PD test to battery feat(analyses-snapshot-testing): adding an OT-2 PD test to battery Apr 30, 2025
Copy link
Member

@y3rsh y3rsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the lint error:

cd analyses-snapshot-testing && \
make setup && \ 
make format

To get CI to open a PR to create the snapshot, I added the label to the PR :)
You should then see a comment about the PR opened into this branch.
If it looks good merge it, wait for everything to pass then you are good.

Approved once all ✅.

@y3rsh y3rsh added the gen-analyses-snapshot-pr Generate a healing PR if the analyses snapshot test fails label Apr 30, 2025
Copy link
Contributor

A PR has been opened to address analyses snapshot changes. Please review the changes here: #18213

@y3rsh
Copy link
Member

y3rsh commented May 1, 2025

A PR has been opened to address analyses snapshot changes. Please review the changes here: #18213

https://github.com/Opentrons/opentrons/pull/18213/files#r2070302421

Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.48%. Comparing base (5c861e5) to head (35c2dac).
Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #18211   +/-   ##
=======================================
  Coverage   57.48%   57.48%           
=======================================
  Files        3043     3043           
  Lines      255276   255276           
  Branches    30517    30517           
=======================================
  Hits       146756   146756           
  Misses     108333   108333           
  Partials      187      187           
Flag Coverage Δ
protocol-designer 18.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 1, 2025

A PR has been opened to address analyses snapshot changes. Please review the changes here: #18213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gen-analyses-snapshot-pr Generate a healing PR if the analyses snapshot test fails
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants