feat(monorepo): transfer command creator overhaul: pt1 #18217
Conversation
This PR begins the work of implementing the new `transfer_liquid` API logic in step generation logic for the `transfer` compound command creator.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18217 +/- ##
===========================================
- Coverage 57.48% 24.08% -33.41%
===========================================
Files 3043 3045 +2
Lines 255267 256275 +1008
Branches 30508 30553 +45
===========================================
- Hits 146752 61733 -85019
- Misses 108328 194525 +86197
+ Partials 187 17 -170
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| ] | ||
| : [] | ||
|
|
||
| export const mixInPlaceUtil = (args: { |
There was a problem hiding this comment.
i'm a bit unclear when you use mixInPlaceUtil vs mixUtil? mixInPlaceUtil is for when you're aspirating in place?
There was a problem hiding this comment.
Correct— I developed mixInPlaceUtil for use in our compound command creators (transfer/consolidate/distribute) for aspirate and submerge mixes, since those mixes are always in place.
There was a problem hiding this comment.
made a first pass at the PR, definitely a heroic task to update the transfer.test.ts file 🚀 😆. left a handful of comments but in general things seem to work. did some smoke testing with step details and adding different fields and nothing broke. Will review again later.
…util for inplace/location mix
Correct, aspirate retract and dispense updates coming in the next PRs. Thank you so much for the reviews |
| minimumZHeight, | ||
| ...(forceDirect != null ? { forceDirect } : {}), | ||
| ...(minimumZHeight != null ? { minimumZHeight } : {}), | ||
| ...(speed != null ? { speed } : null), |
There was a problem hiding this comment.
Hey, I just saw this. We also have to remember to update the Python command below.
…8315) # Overview In PR #18217, @ncdiehl11 added support for the `moveToWell` parameters `forceDirect`, `minimumZHeight`, `speed`. The Python `move_to()` function has the same parameters, and we need to emit those parameters when generating Python. Nick will probably need the `forceDirect` option when implementing liquid class transfers, because our Python `transfer_with_liquid_class()` implementation uses `forceDirect=true` when moving the pipette vertically into and out of the well. ## Test Plan and Hands on Testing Added unit test. ## Risk assessment Low.
Overview
This PR begins the work of implementing the new
transfer_liquidAPI logic in step generation logic for thetransfercompound command creator. Because of the impact of these changes, I have decided to implement the command creator updates incrementally. My planned chunks for implementation are as follows:Test Plan and Hands on Testing
Due to the scope of this PR, I recommend walking through this live with me so I can explain some of the changes made. Please reference the step generation execution doc for correctness as well.
Changelog
app/src/organisms/ODD/QuickTransferFlow/utils/generateQuickTransferArgs.tsso that typechecks passReview requests
see test plan
Risk assessment
medium - high. touches foundational step generation command creator logic