-
Notifications
You must be signed in to change notification settings - Fork 184
feat(app): Add stacker & stacker labware to protocol setup & details #18219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
reviewed
May 1, 2025
app/src/transformations/commands/transformations/getLabwareDefinitionsByURIForProtocol.ts
Outdated
Show resolved
Hide resolved
app/src/organisms/ODD/ProtocolSetup/ProtocolSetupLabware/index.tsx
Outdated
Show resolved
Hide resolved
@@ -426,3 +522,7 @@ function StackedBadge(): JSX.Element { | |||
</RobotCoordsForeignObject> | |||
) | |||
} | |||
|
|||
function getStackerLocationFromSlot(slotName: string): string { | |||
return `${slotName.charAt(0)}4` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh man at some point we really need to get some helper functions to get col/row from slots
7cfad90
to
269494a
Compare
269494a
to
ccda1aa
Compare
sfoster1
approved these changes
May 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me once tests and lint pass! Thank you!
6860cf0
to
996400b
Compare
996400b
to
0779b7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix EXEC-1408, EXEC-1377, EXEC-1339, EXEC-1338, EXEC-1459, EXEC-1460
Overview
This PR adds the Flex Stacker SVG to the deck map, renders labware loaded in the shuttle and hopper on top of it, and adds that labware to protocol setup and details on both ODD and desktop
Test Plan and Hands on Testing
Look at:


Protocol Setup Module Map on ODD and Desktop (list view for this will be implemented in deck config epic):
Protocol Setup Labware List on ODD and Desktop:



Protocol Setup Labware Map on ODD and Desktop:


Protocol Details on ODD and Desktop:



Changelog
getStackedItemsOnStartingDeck
and other command transformation utils so that they include labware loaded through new flex stacker commands. Make helper utils to simplify UI usages of these command outputsSTACKER A
fits in lineReview requests
Look through the code, test it out
Note: one of the files I moved,
getInitialAndMovedLabwareInSlots
is unrelated to these UI updates but seems fishy and is used for deck config compatibility. I made a ticket in the deck config stacker epic to investigate and fix it https://opentrons.atlassian.net/browse/EXEC-1470Risk assessment
Medium - will affect protocol details for all protocols