feat(protocol-designer): update required app version to 8.3.2 #18224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.4.4 #18224 +/- ##
=======================================================
Coverage 21.46% 21.46%
=======================================================
Files 2748 2748
Lines 212336 212336
Branches 7224 7224
=======================================================
Hits 45586 45586
Misses 166743 166743
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jerader
commented
May 1, 2025
| @@ -1,4 +1,3 @@ | |||
| import { useTranslation } from 'react-i18next' | |||
There was a problem hiding this comment.
my prettier by default changed these T_T i guess because the release branch doesn't have the prettier changes that Jamey added? should i fix these? @koji @ncdiehl11
There was a problem hiding this comment.
i'm going to fix it haha
|
I guess we want to go for this since we're making other changes to the PD 8.4.4 branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-1792
Overview
Update required app version to 8.3.2
Test Plan and Hands on Testing
check the overview page
Risk assessment
low