Skip to content

refactor(step-generation): emit mix() api command from mix compound c… #18226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented May 1, 2025

…ommand

closes AUTH-1786

Overview

Emit mix() for python interop now that mix() supports aspirate delay, dispense delay, and final push out

    pipette_left.mix(
        repetitions=2,
        volume=10,
        location=well_plate_1["E12"].bottom(z=1),
        aspirate_delay=5,
        dispense_delay=5,
        final_push_out=20,
    )

Test Plan and Hands on Testing

Review the code and smoke test! i smoke tested and it works as expected

Changelog

  • always emit mix() in python if a mix step is added
  • fix unit tests

Risk assessment

low, behind ff

@jerader jerader requested a review from a team as a code owner May 1, 2025 15:57
@jerader jerader requested a review from ddcc4 May 1, 2025 15:57
Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.49%. Comparing base (8357de4) to head (ccb203b).
Report is 4 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #18226   +/-   ##
=======================================
  Coverage   57.48%   57.49%           
=======================================
  Files        3043     3043           
  Lines      255276   255267    -9     
  Branches    30516    30508    -8     
=======================================
+ Hits       146751   146754    +3     
+ Misses     108338   108326   -12     
  Partials      187      187           
Flag Coverage Δ
protocol-designer 18.93% <72.72%> (+<0.01%) ⬆️
step-generation 4.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tep-generation/src/commandCreators/compound/mix.ts 82.29% <100.00%> (+1.14%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -108,8 +98,13 @@ export function mixUtil(args: {
`location=${labwarePythonName}[${formatPyStr(
well
)}]${formatPyWellLocation(pythonWellLocation)}`,
// TODO (nd, 04/09/2025): uncomment next line once PAPI supports new `final_push_out` arg
// `final_push_out=${finalPushOut}`
...(aspirateDelaySeconds != null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do != 0 as well? I don't want to emit the delay parameter if it's 0.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, good call! thanks

@jerader jerader requested review from ncdiehl11 and ddcc4 May 1, 2025 19:06
@jerader jerader merged commit 150c20c into edge May 1, 2025
18 checks passed
@jerader jerader deleted the sg_mix-api-emit branch May 1, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants