Skip to content

fix(protocol-designer): Fix Designer's page height issue #18227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2025

Conversation

koji
Copy link
Contributor

@koji koji commented May 1, 2025

Overview

cherry pick the pr for AUTH1593 and remove HotKeyDisplay component since it's not compatible with 8.4.4.

Test Plan and Hands on Testing

  1. create/import a protocol
  2. go to Designer page and open TimelineToolbox and a step's Toolbox
  3. chnage Window's height to 664px
    check there isn't white space under Toolboxes and deck view part is scrollable.

Changelog

Review requests

Risk assessment

low

koji and others added 3 commits May 1, 2025 11:50
* fix(protocol-designer): fix height issue in designer page
* fix(protocol-designer): fix height issue in designer page
@koji koji requested review from ncdiehl11 and jerader May 1, 2025 16:15
@koji koji marked this pull request as ready for review May 1, 2025 16:17
@koji koji requested a review from a team as a code owner May 1, 2025 16:17
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 86.11111% with 15 lines in your changes missing coverage. Please review.

Project coverage is 21.47%. Comparing base (3f8243d) to head (82f2ad9).
Report is 1 commits behind head on chore_release-pd-8.4.4.

Files with missing lines Patch % Lines
...esigner/src/pages/Designer/ProtocolSteps/index.tsx 78.57% 12 Missing ⚠️
...tepTools/MoveLabwareTools/LabwareLocationField.tsx 0.00% 1 Missing ⚠️
...rm/StepTools/MoveLabwareTools/MoveLabwareField.tsx 0.00% 1 Missing ⚠️
...er/src/pages/ProtocolOverview/OffdeckThumbnail.tsx 97.72% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-pd-8.4.4   #18227   +/-   ##
=======================================================
  Coverage                   21.46%   21.47%           
=======================================================
  Files                        2748     2748           
  Lines                      212336   212355   +19     
  Branches                     7224     7225    +1     
=======================================================
+ Hits                        45586    45606   +20     
+ Misses                     166743   166742    -1     
  Partials                        7        7           
Flag Coverage Δ
protocol-designer 18.68% <86.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gner/src/pages/Designer/OffDeck/OffDeckDetails.tsx 85.62% <100.00%> (+0.19%) ⬆️
protocol-designer/src/pages/Designer/index.tsx 78.26% <100.00%> (+0.27%) ⬆️
...tepTools/MoveLabwareTools/LabwareLocationField.tsx 4.44% <0.00%> (-0.11%) ⬇️
...rm/StepTools/MoveLabwareTools/MoveLabwareField.tsx 10.52% <0.00%> (-0.59%) ⬇️
...er/src/pages/ProtocolOverview/OffdeckThumbnail.tsx 98.93% <97.72%> (+0.11%) ⬆️
...esigner/src/pages/Designer/ProtocolSteps/index.tsx 90.07% <78.57%> (+0.28%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji added the authorship label May 1, 2025
@koji koji merged commit a2c96aa into chore_release-pd-8.4.4 May 1, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants