-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
feat: Guild Scheduled Event Recurrence #9685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Bump (not sure if it is correct to, my bad if so) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Respecting that this PR is still in draft I wanted to raise a few things before we get too deep into it.
…current_events
…current_events Merge master to recurrent_events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to not use Optional[List[X]]
, it's bad API design.
This has merge conflicts that need to be fixed. |
Merge conflicts should be fixed. |
3717ed6
to
8953938
Compare
Would be great if this was merged to allow for birthday bots, etc! |
@DA-344 I'm new to discord.py, so feel free to ignore this. on_scheduled_event_update caused an Error
removing the 'old_scheduled_event' in parse_guild_scheduled_event_update (d.py/discord/state.py) fixed this. Probably to simple, but worked for me. |
This is not caused by this PR, this is by your code most probably: https://discordpy.readthedocs.io/en/stable/api.html#discord.on_scheduled_event_update |
@OrysB are you perhaps inside of a Cog class and forgot |
huh. Why didn't I spot that. quite obvious. Thanks for the support and this awesome branch! It works very well for my use case. |
Summary
Adds support for Scheduled Events Recurrence.
DDevs Docs PR: discord/discord-api-docs#7058
Checklist