Skip to content

feat: Guild Scheduled Event Recurrence #9685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 57 commits into
base: master
Choose a base branch
from

Conversation

DA-344
Copy link
Contributor

@DA-344 DA-344 commented Dec 14, 2023

Summary

Adds support for Scheduled Events Recurrence.

DDevs Docs PR: discord/discord-api-docs#7058

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Vioshim
Copy link
Contributor

Vioshim commented Jun 7, 2024

Bump (not sure if it is correct to, my bad if so)

Copy link
Contributor

@AbstractUmbra AbstractUmbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Respecting that this PR is still in draft I wanted to raise a few things before we get too deep into it.

@DA-344 DA-344 changed the title Guild Scheduled Event Recurrence & Exceptions feat: Guild Scheduled Event Recurrence Aug 6, 2024
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to not use Optional[List[X]], it's bad API design.

@Rapptz
Copy link
Owner

Rapptz commented Jan 15, 2025

This has merge conflicts that need to be fixed.

@Rapptz Rapptz added the needs review This PR will be reviewed in the future label Jan 15, 2025
@DA-344
Copy link
Contributor Author

DA-344 commented Jan 19, 2025

Merge conflicts should be fixed.

@DA-344 DA-344 requested a review from Rapptz January 20, 2025 16:55
@Rapptz Rapptz removed the needs review This PR will be reviewed in the future label Feb 17, 2025
@Rapptz Rapptz force-pushed the master branch 2 times, most recently from 3717ed6 to 8953938 Compare February 18, 2025 08:29
@Bluscream
Copy link

Would be great if this was merged to allow for birthday bots, etc!

@0Ry5
Copy link

0Ry5 commented Apr 17, 2025

@DA-344 I'm new to discord.py, so feel free to ignore this. on_scheduled_event_update caused an Error

Traceback (most recent call last): File _"/path/to/d.py/discord/client.py",_ line 472, in _run_event await coro(*args, **kwargs) TypeError: on_scheduled_event_update() takes 1 positional argument but 2 were given

removing the 'old_scheduled_event' in parse_guild_scheduled_event_update (d.py/discord/state.py) fixed this. Probably to simple, but worked for me.

@DA-344
Copy link
Contributor Author

DA-344 commented Apr 17, 2025

This is not caused by this PR, this is by your code most probably: https://discordpy.readthedocs.io/en/stable/api.html#discord.on_scheduled_event_update

@LeoCx1000
Copy link
Contributor

@OrysB are you perhaps inside of a Cog class and forgot self?

@0Ry5
Copy link

0Ry5 commented Apr 18, 2025

This is not caused by this PR, this is by your code most probably: https://discordpy.readthedocs.io/en/stable/api.html#discord.on_scheduled_event_update

huh. Why didn't I spot that. quite obvious.

Thanks for the support and this awesome branch! It works very well for my use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScheduledEvent dont't update repeatable events
7 participants