-
Notifications
You must be signed in to change notification settings - Fork 905
avoid exposing asyncio.Future directly to api consumers #5765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
graingert
wants to merge
13
commits into
Textualize:main
Choose a base branch
from
graingert:avoid-exposing-futures-directly-to-consumers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
avoid exposing asyncio.Future directly to api consumers #5765
graingert
wants to merge
13
commits into
Textualize:main
from
graingert:avoid-exposing-futures-directly-to-consumers
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
requested changes
May 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine in principle. Just some requests.
graingert
commented
May 11, 2025
graingert
commented
May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids exposing an 'asyncio.Future' to api consumers - instead returning an awaitable object wrapping an Event and a Result.
Please review the following checklist.
I didn't see any documentation for this feature outside docstrings, it's probably worth a note in the changelog