Add wast source information to JS-converted test cases #1919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossberg
reviewed
Jun 16, 2025
interpreter/script/js.ml
Outdated
Comment on lines
791
to
793
| let source = Filename.basename ass.at.left.file ^ | ||
| ":" ^ string_of_int ass.at.left.line in | ||
| let source_as_arg = ", \"" ^ source ^ "\"" in |
There was a problem hiding this comment.
You'll have to use String.escaped source, otherwise the string literal will be broken if odd characters appear in the name.
There was a problem hiding this comment.
Done, although if any non-ascii chars show up in an input filename, the interpreter fails to load it entirely.
There was a problem hiding this comment.
Ah, I was alluding to backslash or quote characters, but you are right, Unicode is mishandled. I just pushed a fix, and the culprit was: String.escaped. :) Because that produces C-style octal escapes.
But I realised that there already is a proper JS-escaping function in this module: avoid String.escaped and just use the local of_name (which also adds the surrounding quotes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the JS/HTML test conversion outputs a test name for each test, but each name is generic
(such as "#2 Test that WebAssembly compilation succeeds", where the only thing unique is a
prepended number. In the async version, the order of these tests doesn't even correspond
simply to the order of tests in the wast file because each test generates multiple assertions
as promises which do not all resolve together for the same tests. The result is hard to
interpret and debug. This is related to #1860 although this particular issue isn't in the
list there.
This PR adds a "source" argument to various functions and passes the information from
the interpreter's AST through the various conversions into the JS files. The result is test
names such as "#2 Test that WebAssembly compilation succeeds (address.wast:3)".
There are still a few non-unique names. "Reinitialize the default imports" and the wrapper
modules that are used when values can't be passed cleanly to JS aren't updated; but
those modules are not directly part of the feature under test and are less likely to fail,
so it didn't seem worth it.