You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+7-7Lines changed: 7 additions & 7 deletions
Original file line number
Diff line number
Diff line change
@@ -63,27 +63,27 @@ TypeScript is currently accepting contributions in the form of bug fixes. A bug
63
63
64
64
## Contributing features
65
65
66
-
Features (things that add new or improved functionality to TypeScript) may be accepted, but will need to first be approved ([labelled "help wanted"](https://github.com/Microsoft/TypeScript/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22 or in the "Backlog" milestone) by a TypeScript project maintainer) in the suggestion issue. Features with language design impact, or that are adequately satisfied with external tools, will not be accepted.
66
+
Features (things that add new or improved functionality to TypeScript) may be accepted, but will need to first be approved (labelled ["help wanted"](https://github.com/Microsoft/TypeScript/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22) or in the "Backlog" milestone) by a TypeScript project maintainer) in the suggestion issue. Features with language design impact, or that are adequately satisfied with external tools, will not be accepted.
67
67
68
68
Design changes will not be accepted at this time. If you have a design change proposal, please log a suggestion issue.
69
69
70
70
## Legal
71
71
72
72
You will need to complete a Contributor License Agreement (CLA). Briefly, this agreement testifies that you are granting us permission to use the submitted change according to the terms of the project's license, and that the work being submitted is under appropriate copyright.
73
73
74
-
Please submit a Contributor License Agreement (CLA) before submitting a pull request. You may visit https://cla.microsoft.com to sign digitally. Alternatively, download the agreement ([Microsoft Contribution License Agreement.pdf](https://opensource.microsoft.com/pdf/microsoft-contribution-license-agreement.pdf)), sign, scan, and email it back to <cla@microsoft.com>. Be sure to include your GitHub user name along with the agreement. Once we have received the signed CLA, we'll review the request.
74
+
Please submit a Contributor License Agreement (CLA) before submitting a pull request. You may visit https://cla.microsoft.com to sign digitally. Alternatively, download the agreement ([Microsoft Contribution License Agreement.pdf](https://opensource.microsoft.com/pdf/microsoft-contribution-license-agreement.pdf)), sign, scan, and email it back to <cla@microsoft.com>. Be sure to include your GitHub user name along with the agreement. Once we have received the signed CLA, we'll review the request.
75
75
76
76
## Housekeeping
77
77
78
-
Your pull request should:
78
+
Your pull request should:
79
79
80
80
* Include a description of what your change intends to do
81
-
* Be a child commit of a reasonably recent commit in the **master** branch
81
+
* Be a child commit of a reasonably recent commit in the **master** branch
82
82
* Requests need not be a single commit, but should be a linear sequence of commits (i.e. no merge commits in your PR)
83
83
* It is desirable, but not necessary, for the tests to pass at each commit
84
-
* Have clear commit messages
84
+
* Have clear commit messages
85
85
* e.g. "Minor refactor in goToTypeDefinition", "Fix iterated type in for-await-of", "Add test for preserveWatchOutput on command line"
86
-
* Include adequate tests
86
+
* Include adequate tests
87
87
* At least one test should fail in the absence of your non-test code changes. If your PR does not match this criteria, please specify why
88
88
* Tests should include reasonable permutations of the target fix/change
89
89
* Include baseline changes with your change
@@ -133,7 +133,7 @@ e.g. to run all compiler baseline tests:
133
133
gulp runtests --tests=compiler
134
134
```
135
135
136
-
or to run a specific test: `tests\cases\compiler\2dArrays.ts`
136
+
or to run a specific test: `tests\cases\compiler\2dArrays.ts`
0 commit comments