-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore(actions): run test suite against PRs and on label #14372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the example runs and explanation. Maybe we should remove this action: https://github.com/aws-amplify/amplify-js/blob/main/.github/workflows/push-integ-test.yml since it's essentially replaced by this change.
Co-authored-by: AllanZhengYP <zheallan@amazon.com>
Co-authored-by: AllanZhengYP <zheallan@amazon.com>
context: 'Run PR e2e checks' | ||
description: 'PR e2e checks are now running' | ||
# URL below is a link to the current workflow run to allow users to see the status of the workflow. | ||
target-url: https://github.com/${{ github.event.repository.owner.login }}/${{ github.event.repository.name }}/actions/runs/${{ github.run_id }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any validation on target-url? If not, please restrict this to only expected input (min/max length, malicious characters, etc).
Description of changes
Currently, to run e2e tests before merging a PR we need to manually push the changes to another branch on upstream and update the
push-integ-test
workflow by updating the trigger branch name. With this change you can directly add therun-tests
label and it should start running the E2E tests.Implementation reference taken from UI
(Note: currently only configured for main/release. Can be updated to all branches if required)
Conditions
run-tests
labelDescription of how you validated changes
Tested the following flows
Flow 1
Flow 2
Failure case (CI run)

Success case (CI run)

Checklist
yarn test
passesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.