feat(rtn-passkeys): add ios support - 3a #14392
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjarvisp
changed the title
jjarvisp
force-pushed
the
feat/rtn-passkeys/2-modify-existing-impl
branch
from
abd18da to
8065ea4
Compare
jjarvisp
force-pushed
the
feat/rtn-passkeys/3a-add-ios-support
branch
2 times, most recently
from
c993348 to
8669899
Compare
AllanZhengYP
approved these changes
May 21, 2025
There was a problem hiding this comment.
Nit: The indentation of this file is a bit weird with mix of tab and spaces.
Comment on lines
+42
to
+43
| switch authorization.credential { | ||
| case let assertionCredential |
| errorName: errorName, errorMessage: errorMessage, error: error) | ||
| } | ||
|
|
||
| func presentationAnchor(for controller: ASAuthorizationController) |
There was a problem hiding this comment.
Question: what's this function for?
jjarvisp
force-pushed
the
feat/rtn-passkeys/3a-add-ios-support
branch
from
8669899 to
b55f3a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The purpose of this PR is to add iOS support for the React Native implementation of webauthn.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.