Skip to content

[FEATURE] Support Int64/Float32/Float64 to be bound with corresponding numpy number types #616

@badmonster0

Description

@badmonster0

In #586 and #595 we added support to bind Vector[Int64], Vector[Float32] and Vector[Float64] (as CocoIndex data types) to corresponding numpy array types like NDArray[numpy.int64], NDArray[numpy.float32] and NDArray[numpy.float64].

For consistency and composability, we want to support numpy type binding on scalar number level too. e.g.
Users should be able to use numpy.int64 for a field with Int64 type, etc.

Also see a related comment #595 (comment) for implementation hint:

BTW, actually I was thinking np_number_type should be a property for the element type, instead of the vector type. It should resolve information one level at a time, and it'll also allows us consistently support individual np.float32 types outside a vector - if we want to support it.


❤️ Contributors, please refer to 📙Contributing Guide.
Unless the PR can be sent immediately (e.g. just a few lines of code), we recommend you to leave a comment on the issue like I'm working on it or Can I work on this issue? to avoid duplicating work. Our Discord server is always open and friendly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needed

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions