Actions loaded are missing hyphens #415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 10, 2023 16:27
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vineeth-asml
approved these changes
Aug 14, 2023
jsiever1
approved these changes
Aug 14, 2023
rajbos
changed the title
rajbos
reviewed
Aug 28, 2023
| @@ -45,6 +43,7 @@ export function parseYAML( | |||
| } | |||
| return {name, author, description, using} | |||
| } | |||
| const removeGreaterLessThan = (item:string) => item.replace(/\>/g,'>').replace(/\</g,'<') | |||
There was a problem hiding this comment.
You are now bypassing the sanitize method completely, which I added for a reason :-D. Can we embed this code into the sanitize function and revert to calling that code again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since only way to inject malicious code in name/author is html tags, the full special character stripping is changed to replacing > and < with their corresponding ascii character codes.
This change required test adjustments.