Transport.Quic.Tests: don't fail on distros that don't have quic. #46662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test suite has a test that unconditionally fails when quic is not supported. The test is meant to ensure quic tests are executed. Instead of running the test everywhere, this changes it to run only on Microsoft CI, where CI configurations are expected to have quic installed.
tmds
requested review from
Tratcher,
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
ghost
added
area-runtime
community-contribution
|
Thanks for your PR, @tmds. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
JamesNK
reviewed
Feb 15, 2023
JamesNK
approved these changes
Feb 18, 2023
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite has a test that unconditionally fails when quic is not supported. The test is meant to ensure quic tests are executed.
Instead of running the test everywhere, this changes it to run only on Microsoft CI, where CI configurations are expected to have quic installed.
This change is similar to dotnet/runtime#82108.
@dougbu ptal.
cc @omajid