Avoid closures in CheckIfCacheMissOnReferencedProjectIsAllowedAndErro… #11990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the method CheckIfCacheMissOnReferencedProjectIsAllowedAndErrorIfNot by removing closures and converting lambdas into static methods to avoid capturing instance state. Additionally, it updates helper methods (e.g., GetConfigurations, SkipNonexistentTargetsIfExistentTargetsHaveResults, and GetLoggingServiceAction) to use explicit parameters instead of relying on instance fields.
- Replaced closure-based lambdas with static lambdas.
- Modified helper methods to accept config and results caches as arguments.
- Refactored the flow for retrieving the parent request within GetConfigurations.
rainersigwald
approved these changes
Jun 13, 2025
SimaTian
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rIfNot
Fixes #
Context
Changes Made
Testing
Notes