Switch MethodImplAttributes.Async to 0x2000 #78536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was changed in dotnet/runtime#114310 as 0x400 is a thing in framework.
agocke
approved these changes
May 9, 2025
| @@ -1762,7 +1762,7 @@ internal override System.Reflection.MethodImplAttributes ImplementationAttribute | |||
| // PROTOTYPE: Use real value from MethodImplAttributes when available | |||
There was a problem hiding this comment.
You could do this now, I think. That is, look in the ref assembly for MethodImplAttributes.Async, then write that value in.
There was a problem hiding this comment.
We don't do anything like that today. We'll just wait for the MethodImplAttributes that we consume to update.
RikkiGibson
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was changed in dotnet/runtime#114310 as 0x400 is a thing in framework.
Relates to test plan #75960