Skip to content

Fix analyzer RCS1250: Don't suggest a collection expression for the Dictionary #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aihnatiuk
Copy link

Fixes #1641

Hello, I am new to this project and to the Roslyn in general, this is my first contribution here.
I hope I got the idea right.

@aihnatiuk
Copy link
Author

@dotnet-policy-service agree

@aihnatiuk aihnatiuk force-pushed the RCS1250-collection-expression-fix branch from 03cb36e to ceaa8dc Compare May 8, 2025 09:53
ChangeLog.md Outdated
@@ -27,6 +27,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fix analyzer [RCS1174](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1174) ([PR](https://github.com/dotnet/roslynator/pull/1619))
- Fix analyzer [RCS0010](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS0010) ([PR](https://github.com/dotnet/roslynator/pull/1620))
- Fix analyzer [RCS0005](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS0005) ([PR](https://github.com/dotnet/roslynator/pull/1621))
- Fix analyzer [RCS1250](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1250) ([PR](https://github.com/dotnet/roslynator/pull/1652))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move it to "Unreleased" section

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josefpihrt Sorry, my bad. Done.

@aihnatiuk aihnatiuk force-pushed the RCS1250-collection-expression-fix branch from ceaa8dc to 6df228e Compare May 26, 2025 07:41
@aihnatiuk aihnatiuk requested a review from josefpihrt May 26, 2025 07:47
@aihnatiuk
Copy link
Author

@josefpihrt Something is wrong with the pipeline. Do not think this is my fault but correct me if I'm wrong. Could you rerun please?

@josefpihrt
Copy link
Collaborator

I rerun it, it should help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RCS1250 fixer generates invalid syntax for Dictionaries
2 participants