Skip to content

[Perf] Linux/x64: Span.IndexerBench Regression + Related Issues on 2/6/2025 4:29:54 PM +00:00 #112430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
performanceautofiler bot opened this issue Feb 11, 2025 · 3 comments
Assignees
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue ViperUbuntu
Baseline adb2af26bb6bb19312c38cacda2694b981b56c6d
Compare 9c2bfb9ab73961d149ea263c7a78606bfb4bc0b4
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in Span.IndexerBench

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
713.95 ns 845.70 ns 1.18 0.03 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'Span.IndexerBench*'

Span.IndexerBench.CoveredIndex3(length: 1024)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-x64 os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Feb 11, 2025
@LoopedBard3 LoopedBard3 transferred this issue from dotnet/perf-autofiling-issues Feb 11, 2025
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 11, 2025
@LoopedBard3 LoopedBard3 changed the title [Perf] Linux/x64: 1 Regression on 2/6/2025 4:29:54 PM +00:00 [Perf] Linux/x64: Span.IndexerBench Regression on 2/6/2025 4:29:54 PM +00:00 Feb 11, 2025
@LoopedBard3 LoopedBard3 added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Feb 11, 2025
@LoopedBard3
Copy link
Member

LoopedBard3 commented Feb 11, 2025

@LoopedBard3 LoopedBard3 changed the title [Perf] Linux/x64: Span.IndexerBench Regression on 2/6/2025 4:29:54 PM +00:00 [Perf] Linux/x64: Span.IndexerBench Regression + Related Issues on 2/6/2025 4:29:54 PM +00:00 Feb 11, 2025
@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 12, 2025
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Feb 12, 2025
@JulieLeeMSFT JulieLeeMSFT added this to the 10.0.0 milestone Feb 12, 2025
@amanasifkhalid amanasifkhalid removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 12, 2025
@amanasifkhalid
Copy link
Member

The Span.IndexerBench regression improved, and then later regressed again (probably due to #113896). This should be tracked in a newer issue.

Some of the Perf_128 regressions in dotnet/perf-autofiling-issues#49898 improved from #111915, while others regressed further. Since those regressions are on an Intel config with the JCC erratum, I'm not weighting them as heavily. Similarly, the remaining regressions should be tracked in a newer issue.

@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

4 participants