-
Notifications
You must be signed in to change notification settings - Fork 5k
[RuntimeAsync] PGO support. #115096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Tagging subscribers to this area: @mangod9 |
I assume by async variants you mean specifically the runtime provided thunks. I believe PGO already works fine in the methods with user provided IL (at least it was the case a few months ago). |
I did not look in details if it is only thunks that we do not support. This is just an issue to make sure we act on TODOs in that area. I am not sure how much thunks can dynamically learn and improve something. |
You did the work in dotnet/runtimelab#2818 (comment) to ensure tiered compilation and PGO worked (in the first version the PR broke it.)
Yeah, this would likely be around inlining. But yes, it likely is not super important, and it is not clear if we would even benefit from it. I also believe there currently is no tiering at all for the runtime provided stubs (so they are always compiled in tier 1). |
Ah, right. I remember there was a major issue with tiering as we got confused which of the two variants we are dealing with. I guess PGO is working in scenarios where we allow tiering. |
Re: #114675 (comment)
Right now async variants are explicitly excluded from PGO.
No fundamental reason for that, it is just an NYI that needs to be revisited, implemented, tested.
The text was updated successfully, but these errors were encountered: